Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3175466ybl; Mon, 20 Jan 2020 17:42:01 -0800 (PST) X-Google-Smtp-Source: APXvYqzgFWAfPogfP5g/AhyRBf6etaruWwn5E4REz06aEWOOC2NnWdRLB7DEFHWomi5M36+s5Y4x X-Received: by 2002:aca:490e:: with SMTP id w14mr1266639oia.67.1579570921238; Mon, 20 Jan 2020 17:42:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579570921; cv=none; d=google.com; s=arc-20160816; b=cp18Kuhf2yw0rlUXSnsNLhRJG7phS0XbJZN+F7z4XBoPeGTer91pB6/DHJSB/jzp0v /rdMIokSwb8/wlilva7dIEGJLdrO/yapYdT3QyTCkG1rvf1RE5qQ4Tc7a3EWdV/QpQgM rKD7cIplBkpwAS3nwVboRG98ykeKp5RzJEZ10KRC16RmVhQ94GKGkldwpIaJXzZCiAcc XiZMD5DWcDByEhBE39wJJtC9v+MlRls/SOGbIDPZ4UnDo2TJgJonDq/vpC/dBKKNoS75 OtMIeAcEIjUcAsJCWSFKwWbA/07952nY/rRYMNpl2GVC2WQV240lh92YMAdxwyEkYk1X fIZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=TN9czfLKzQSsyAAEWct6KHdMIGQ5uS9yqSFqzIN0Nt0=; b=H2mV56u6olRa2jt3/u9YcklGi15FwFMV1FhBJ8Vha4LtpcFvM66+BY+vJzSYRUtI4J 8mgf4Fd57RElWnCq0WnOqELIuFLEHt9Z4D3OxPDRUC8DeuNLwYq9KlZo19tKf39vIJ6a jC6MmmHFtyvVeMPGmMCAVJVC6efZWw6Yefl/IXaY33btJGyL9rKgd/i2WDDHR4XwypEc wl582uMgGNPtOlRil1sg5kIABC5cCLIIqHNe2BFmvUy7wMkYocQm6HrZvL1C8Xf1pHyb l61cuApOrzZDXo0hpQo+D3CRNdT9x152zgOLhmnK3MspzfMfA6v7julamefq787MoXac rzvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h22si21937578otk.18.2020.01.20.17.41.49; Mon, 20 Jan 2020 17:42:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728896AbgAUBk5 (ORCPT + 99 others); Mon, 20 Jan 2020 20:40:57 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:37266 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726935AbgAUBk5 (ORCPT ); Mon, 20 Jan 2020 20:40:57 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4E2F0CAE3A7004B61A4B; Tue, 21 Jan 2020 09:40:54 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Tue, 21 Jan 2020 09:40:43 +0800 From: Chen Zhou To: , , CC: , , Subject: [PATCH -next] drivers: net: declance: fix comparing pointer to 0 Date: Tue, 21 Jan 2020 09:35:53 +0800 Message-ID: <20200121013553.15252-1-chenzhou10@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes coccicheck warning: ./drivers/net/ethernet/amd/declance.c:611:14-15: WARNING comparing pointer to 0 Compare pointer-typed values to NULL rather than 0. Signed-off-by: Chen Zhou --- drivers/net/ethernet/amd/declance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c index 6592a2d..7282ce5 100644 --- a/drivers/net/ethernet/amd/declance.c +++ b/drivers/net/ethernet/amd/declance.c @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev) len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; skb = netdev_alloc_skb(dev, len + 2); - if (skb == 0) { + if (!skb) { dev->stats.rx_dropped++; *rds_ptr(rd, mblength, lp->type) = 0; *rds_ptr(rd, rmd1, lp->type) = -- 2.7.4