Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161010AbWBAKsZ (ORCPT ); Wed, 1 Feb 2006 05:48:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161014AbWBAKsZ (ORCPT ); Wed, 1 Feb 2006 05:48:25 -0500 Received: from ns1.suse.de ([195.135.220.2]:55970 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1161010AbWBAKsX (ORCPT ); Wed, 1 Feb 2006 05:48:23 -0500 From: Andi Kleen To: Michael Tokarev Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Date: Wed, 1 Feb 2006 11:24:27 +0100 User-Agent: KMail/1.8.2 Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@vger.kernel.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel References: <20060201090224.536581000@localhost.localdomain> <200602011006.09596.ak@suse.de> <43E07EB2.4020409@tls.msk.ru> In-Reply-To: <43E07EB2.4020409@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200602011124.29423.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 26 On Wednesday 01 February 2006 10:26, Michael Tokarev wrote: > Andi Kleen wrote: > > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > > > >>+static inline unsigned int hweight32(unsigned int w) > [] > > How large are these functions on x86? Maybe it would be better to not inline them, > > but put it into some C file out of line. > > hweight8 47 bytes > hweight16 76 bytes > hweight32 97 bytes > hweight64 56 bytes (NOT inlining hweight32) > hweight64 197 bytes (inlining hweight32) > > Those are when compiled as separate non-inlined functions, > with pushl %ebp and ret. This would argue for moving them out of line. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/