Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] dmaengine: fsl-qdma: fix duplicated argument to &&
To:     Peng Ma <peng.ma@nxp.com>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>
References: <20200120125843.34398-1-chenzhou10@huawei.com>
 <VI1PR04MB44314C51FA4C397F352C14C8ED0D0@VI1PR04MB4431.eurprd04.prod.outlook.com>
CC:     "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From:   Chen Zhou <chenzhou10@huawei.com>
Message-ID: <96b96dda-0fdc-bbc1-cdb8-b7d0f20940e7@huawei.com>
Date:   Tue, 21 Jan 2020 11:28:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <VI1PR04MB44314C51FA4C397F352C14C8ED0D0@VI1PR04MB4431.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Peng,

On 2020/1/21 10:54, Peng Ma wrote:
> 
> 
>> -----Original Message-----
>> From: Chen Zhou <chenzhou10@huawei.com>
>> Sent: 2020??1??20?? 20:59
>> To: dan.j.williams@intel.com; vkoul@kernel.org
>> Cc: Peng Ma <peng.ma@nxp.com>; Wen He <wen.he_1@nxp.com>;
>> jiaheng.fan@nxp.com; dmaengine@vger.kernel.org;
>> linux-kernel@vger.kernel.org; chenzhou10@huawei.com
>> Subject: [PATCH -next] dmaengine: fsl-qdma: fix duplicated argument to &&
>>
>> There is duplicated argument to && in function fsl_qdma_free_chan_resources,
>> which looks like a typo, pointer fsl_queue->desc_pool also needs NULL check,
>> fix it.
>> Detected with coccinelle.
>>
> What does the " coccinelle " mean here?

The scripts in kernel dir, that is coccicheck.

Thanks,
Chen Zhou

> 
>> Fixes: b092529e0aa0 ("dmaengine: fsl-qdma: Add qDMA controller driver for
>> Layerscape SoCs")
>> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
>> ---
>> drivers/dma/fsl-qdma.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index
>> 8979208..95cc025 100644
>> --- a/drivers/dma/fsl-qdma.c
>> +++ b/drivers/dma/fsl-qdma.c
>> @@ -304,7 +304,7 @@ static void fsl_qdma_free_chan_resources(struct
>> dma_chan *chan)
>>
>> 	vchan_dma_desc_free_list(&fsl_chan->vchan, &head);
>>
>> -	if (!fsl_queue->comp_pool && !fsl_queue->comp_pool)
>> +	if (!fsl_queue->comp_pool && !fsl_queue->desc_pool)
>> 		return;
>>
> Hi Chen,
> 
> Thanks very much for your patch, It is really need to check comp_pool and desc_pool here.
> Reviewed-by: Peng Ma <peng.ma@nxp.com>
> Tested-by: Peng Ma <peng.ma@nxp.com>
> 
> BR,
> Peng
>> 	list_for_each_entry_safe(comp_temp, _comp_temp,
>> --
>> 2.7.4
>