Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3288685ybl;
        Mon, 20 Jan 2020 20:43:16 -0800 (PST)
X-Google-Smtp-Source: APXvYqz5eg3FD/fHd8PBeNGvsmqaA4SnKo5SVaS0jHrXRsgb6fiuGkf6dxahET9v5GaUzToz80Nw
X-Received: by 2002:a05:6808:8d5:: with SMTP id k21mr1689039oij.121.1579581796156;
        Mon, 20 Jan 2020 20:43:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1579581796; cv=none;
        d=google.com; s=arc-20160816;
        b=CG7o7Urd/+s3BfdwABc2UlHnbQAdqdUhuj6+ehBJ1fgs6gTIMigNS3GqCgqdxs5a0v
         7uliFM9K/h7MXX0c36x2PL4EitZV8y37Hu4pUgPyOQ04gtfI9cGG4lIQsCzC6figd+wo
         kn5CcQUTLm0oKWRAq5cCBQ2XXFlkNXarpx3wAHnTzrNMABva9Urun1nKNv4UVkaf9P0C
         bIX1gGFBtZ+HyWzY3Sn9IUuTNqxOCFxDRfyQVS0CsQa+D9HwvlIJhmypU4sByIuf02sR
         JdRhJq9W67M0QrQr4wwQx7+9WXj9lcnNUSGVlXE7E89EnzLNCmQaX5HfzVnNy2/TS+Kx
         Q4nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=GRt9U4PodCr86yU5eOb42L+DV/cuxomWCgBuTVfGcsY=;
        b=q2aUvJHLs2amferOgGaU0ljDuUbIVw71LA88vBJ5i7FMg0n7y+wH7iaVmkPWxR77YX
         TZt7rTSq1bztQMwFWItF7rXYmobpXWsYNcPNhUcXPQNziFJsMkM8tYPvj5WlTxGw1iPx
         HS+3N/H2Ts+SNSWqhs9qRlCAIgYXX62Ky9d8f8dB6DtqP0Bn8rtML2B/mKPYmQVhNh01
         l6CBElnaUEqL3sfSQtiGQuix8lgjcst/FpE6shHtr1402XnFaIFgRbWiLhibwPbpEXI4
         UCv5k353wcOHc/54wc6Trcj/MXhvDHKw94YShhJqerlGkuCnVfS11PWIaIvHoRW7NQuf
         JPtw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=EnKysQf2;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id k13si18102478oij.118.2020.01.20.20.43.04;
        Mon, 20 Jan 2020 20:43:16 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=EnKysQf2;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728843AbgAUElZ (ORCPT <rfc822;lans.zhang2008@gmail.com>
        + 99 others); Mon, 20 Jan 2020 23:41:25 -0500
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:16995 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728042AbgAUElZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Jan 2020 23:41:25 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e2680e50000>; Mon, 20 Jan 2020 20:41:09 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 20 Jan 2020 20:41:24 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 20 Jan 2020 20:41:24 -0800
Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 21 Jan
 2020 04:41:19 +0000
Subject: Re: [alsa-devel] [PATCH 2/9] ASoC: tegra: add support for CIF
 programming
To:     Dmitry Osipenko <digetx@gmail.com>, <perex@perex.cz>,
        <tiwai@suse.com>, <robh+dt@kernel.org>
CC:     <devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        <atalambedu@nvidia.com>, <linux-kernel@vger.kernel.org>,
        <lgirdwood@gmail.com>, <jonathanh@nvidia.com>,
        <viswanathl@nvidia.com>, <sharadg@nvidia.com>,
        <broonie@kernel.org>, <thierry.reding@gmail.com>,
        <linux-tegra@vger.kernel.org>, <rlokhande@nvidia.com>,
        <mkumard@nvidia.com>, <dramesh@nvidia.com>
References: <1579530198-13431-1-git-send-email-spujar@nvidia.com>
 <1579530198-13431-3-git-send-email-spujar@nvidia.com>
 <d01ed171-d949-19b2-3390-ee30eada2779@gmail.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <a8409b81-7c6b-37a9-81fd-772eb2eca185@nvidia.com>
Date:   Tue, 21 Jan 2020 10:11:16 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <d01ed171-d949-19b2-3390-ee30eada2779@gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1579581669; bh=GRt9U4PodCr86yU5eOb42L+DV/cuxomWCgBuTVfGcsY=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=EnKysQf2VsOESTATJ6csnBbQLyGt6UD8fN0ZDiNDa5pHNJZPSq756z+cvYTNkkbUR
         UJFZvBvLGpXkRtSCG6VeBOwje4GuJ/bIGrtWbWabJb0ytEuAMf6OEmXj9QY1+i7Eij
         wY3N0EifVoSVE7jDcRa9T6gakYcJnbOGb/VyUmy/kYDYFVL/KDJo0Tj7LpzUecg/G4
         m4FUDbKigHjs669jxNj15+GX06SaH0850lcGpK38nDe6IjhcTKbqFbvm4D3L1wwk2R
         cgEfj67npqikvcgyjnrnyOpigqYZ37U+8rY75ZlUoykyl7mmLnBsNDuOc931gti59l
         QbwzC5wDwFsQQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/20/2020 9:28 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> Hello Sameer,
>
> 20.01.2020 17:23, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>
> [snip]
>
>> Tegra30 and Tegra124 have an identical CIF programming helper function.
> [snip]
>
>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT  24
>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK_US        0x3f
>> -#define TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_MASK   (TEGRA124_AUDIOCIF=
_CTRL_FIFO_THRESHOLD_MASK_US << TEGRA124_AUDIOCIF_CTRL_FIFO_THRESHOLD_SHIFT=
)
>> -
>> -/* Channel count minus 1 */
>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT   24
>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK_US 7
>> -#define TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_MASK    (TEGRA30_AUDIOCIF_=
CTRL_AUDIO_CHANNELS_MASK_US << TEGRA30_AUDIOCIF_CTRL_AUDIO_CHANNELS_SHIFT)
> The AUDIOCIF_CTRL bitfields are not the same on T30 and T124, why are
> you claiming that programming is identical? Have you actually tried to
> test these patches on T30?

Oh yes! seems like I overlooked the macro values. Thanks for pointing=20
this. I will retain separate CIF function for Tegra30.
I do not have a Tegra30 board with me and hence could not test anything=20
specific to it apart from build sanity.
If someone can help me test I would really appreciate.