Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3297503ybl; Mon, 20 Jan 2020 20:58:51 -0800 (PST) X-Google-Smtp-Source: APXvYqxTxbJGvH50xDlfajLF87Uh4JS2QwmG9xNvl1X3sjiUXpMv4oEpFGgi5mb2EFxftgTsLea5 X-Received: by 2002:aca:d887:: with SMTP id p129mr1659128oig.51.1579582731421; Mon, 20 Jan 2020 20:58:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579582731; cv=none; d=google.com; s=arc-20160816; b=a9OQr6RgZe/1EJltp+uvlvLeRvT5SvB94DL7+lzu/TPkuOrImJvP8nYsLUW36io1/h sGkxSsWkJSAvs+9CPoENwZXQA60YD064wRu9VQNXgTEhZClBcKtL15DvmmYvkSwYiH6B PZ7yyX5TUwc7pelQwDWSaqjwiWkLeCYT3Qft0qsl87tIUyCqj3KCDWYvy6zkp83epy1W 8KHWTMjAS/N8K+prCkbANLHZY6q1lto5KSEZsBL1TnZrXZNq+Bq539xHs+VDZloUz9D3 OWPFegaw/XNzTiEDirENpsiiui6n40xwJqsV+xiO0fz/dT7RUswpn/zFmnZmrIOkpWvn Gicg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=D3T06gwDNjBQHSf+WeTRUnSjC80olQKqYVFDvKvxLVs=; b=WkuhC9HeLEy3ba0zMeon3ZHU0ECXmfR6jmSbQAcdRO5T8rKHRzqS/NfSi3AJzYX3/W W6DgaMGfHPOC7bg8k5Et9A8wdhSqucyAJxmJJhonJtETb6lIKiAPHm0mBsGCoflvT7Yg yiJlJ00tbD+tRG3pRM0GGiLIk9JcJsvGvZd0vI9QfDvvDOVlwe9roi2v41QtoVKGdvME OfhABtgUi82lCR+IytI3T6JF3DxYzkwEXVrtr079cdg5EwSl1p/cYrWSVMGlSKGFWq32 EBoh3PoBwDkOKAPEaS+tL9Cj8aTovbUlZ7ShiEyG7LK+UYSyHQydl9L5EaYqVRiErc1i i30g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=p5SDxcMW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 38si22490710otj.136.2020.01.20.20.58.37; Mon, 20 Jan 2020 20:58:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=p5SDxcMW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728760AbgAUE4g (ORCPT + 99 others); Mon, 20 Jan 2020 23:56:36 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:33666 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728093AbgAUE4g (ORCPT ); Mon, 20 Jan 2020 23:56:36 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00L4rMVV065996; Tue, 21 Jan 2020 04:56:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=D3T06gwDNjBQHSf+WeTRUnSjC80olQKqYVFDvKvxLVs=; b=p5SDxcMW3zP4iXZmJVcBOWw8Gao/u94hBkLgwt7GCNLMXXdvMs0XELG2uDeiEmXqwroP wUJja5j5HFKZ8ANivcRVkxgcGkG4B3FoN2DsZY+bjZyGq3dSzh7WKpyGqaCGOva7m/Ki AF79OMjl2s/SbLIwHL+mtkKSpCDmOJdaySEpaO4SnHR0IMlmjqOnyb+y945vXMnJoe7Z 0XwvF1jQe3CzbSrWFVjgSJzQEkMVwDhdcz5mN8MJRXRIhSbNyU7pc42cJR+o56EyOo7Y WSfpQD92iCz4dm+9b/tjRcg+JMTg565iMNtLwi0pODmXqO8kx8G9qvcWQPf30OLLAehC Zg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2xksyq2f2q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 04:56:29 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00L4rMFT044784; Tue, 21 Jan 2020 04:56:28 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2xnpfn97qb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 04:56:28 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 00L4uQ2f006166; Tue, 21 Jan 2020 04:56:26 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 20 Jan 2020 20:56:26 -0800 To: hare@suse.de Cc: Igor Druzhinin , , , , , Subject: Re: [PATCH RESEND 0/2] Fixing libfc memory leaks From: "Martin K. Petersen" Organization: Oracle Corporation References: <1579013000-14570-1-git-send-email-igor.druzhinin@citrix.com> Date: Mon, 20 Jan 2020 23:56:24 -0500 In-Reply-To: <1579013000-14570-1-git-send-email-igor.druzhinin@citrix.com> (Igor Druzhinin's message of "Tue, 14 Jan 2020 14:43:18 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9506 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=635 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210042 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9506 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=697 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210042 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hannes, > Could you take a look at those? > At least the first one causes noticeable memory decline over time > for some of our deployments. > > Igor Druzhinin (2): > scsi: libfc: free response frame from GPN_ID > scsi: libfc: drop extra rport reference in fc_rport_create() > > drivers/scsi/libfc/fc_disc.c | 2 ++ > drivers/scsi/libfc/fc_rport.c | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) Please review! -- Martin K. Petersen Oracle Linux Engineering