Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3402795ybl; Mon, 20 Jan 2020 23:35:32 -0800 (PST) X-Google-Smtp-Source: APXvYqy5/7D3p1ataIbRO+mnxEgkpu7iBfysXERPc/bEqCaRFDak0o6EWqJh2IjjyEh1KBLHs8Qh X-Received: by 2002:aca:6042:: with SMTP id u63mr2093241oib.76.1579592132124; Mon, 20 Jan 2020 23:35:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579592132; cv=none; d=google.com; s=arc-20160816; b=gvVIata8VOnPp0HLJjYi6pOyTQsFAEPtk12ucsBhi0hCucoGiG6w/sSGZTgw+UCrmm 4sHf68MHDhu2iRfRfzpgUfvKrQz3gIQdx5nTS6K6oazRZGpDgM7VXPJVO5njltPv+08P +amqvIztrRr98cjAW9fxALQp6+jdRLQucLkR4zN0oD8AMTHIStu+fwDMB9o2YUpOgnkK QVuhENQ8PYC/UW42U2eJuZ3Dd9EyRv3MuPFEAsHl1WTMIMd7siw3gBrrLS8AOgn/NhkT J5QKZwEwPi1vqt9fvEZ5zBTmhhi1kI+taJmMqCpX9+NK+e3AXdog7Ywo55ZVlhRvJ260 XP+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from; bh=kbZIOHC2AMT+fEi2VnijQcoNZYNOYCBF4EeVLLm0zvQ=; b=izX7DkXgmJPaFQlrC6uGcta6aQRGeV6BsikOAh5aTMcUH5BcNI6DgLovYkjNuPjrRe LZAaUMcrPgyUMxmzcfm80/vtrPgvW2OghTng86AohFfuVoiBSOsja948KWlWar0aHni1 nz5p84Ha7ADThJhyodZ8q2JQQuC7b6Hhh5qp8SlZHtFUAfnfPP1Hrv1BAcTyNKSnhYGz P6TE8WLFbW0nO3pbW/Ce+yplaQ/Mj2xgAK4YSAZ75szU2LmeKCP8GYGQl7YfIec7/NZx 58ziD4kXrfJs5qKL4V7VelxKOxYn/ZMkNgvwp1hney/tjpD8Yc7FPT/mAC3W06B0kvpW 8R9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w26si22049599otp.239.2020.01.20.23.35.19; Mon, 20 Jan 2020 23:35:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728682AbgAUHeY (ORCPT + 99 others); Tue, 21 Jan 2020 02:34:24 -0500 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]:41937 "EHLO out30-56.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbgAUHeX (ORCPT ); Tue, 21 Jan 2020 02:34:23 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R991e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0ToHExQp_1579592060; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0ToHExQp_1579592060) by smtp.aliyun-inc.com(127.0.0.1); Tue, 21 Jan 2020 15:34:20 +0800 From: Alex Shi Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] btrfs: remove unused actions Date: Tue, 21 Jan 2020 15:34:19 +0800 Message-Id: <1579592059-86386-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seems no one care ret and features in func btrfs_sysfs_feature_update, so better to remove them. Signed-off-by: Alex Shi Cc: Chris Mason Cc: Josef Bacik Cc: David Sterba Cc: linux-btrfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/btrfs/sysfs.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 5ebbe8a5ee76..93f870727aa7 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -1148,13 +1148,10 @@ void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info, { struct btrfs_fs_devices *fs_devs; struct kobject *fsid_kobj; - u64 features; - int ret; if (!fs_info) return; - features = get_features(fs_info, set); ASSERT(bit & supported_feature_masks[set]); fs_devs = fs_info->fs_devices; @@ -1168,7 +1165,7 @@ void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info, * to use sysfs_update_group but some refactoring is needed first. */ sysfs_remove_group(fsid_kobj, &btrfs_feature_attr_group); - ret = sysfs_create_group(fsid_kobj, &btrfs_feature_attr_group); + sysfs_create_group(fsid_kobj, &btrfs_feature_attr_group); } int __init btrfs_init_sysfs(void) -- 1.8.3.1