Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3402798ybl; Mon, 20 Jan 2020 23:35:32 -0800 (PST) X-Google-Smtp-Source: APXvYqw2sskUzKbHWdxeIF2QbXtkohkzEilR0L3HxoooYfaiJGAdbRTd4hTd0ezdRczEPWEtihjQ X-Received: by 2002:a9d:68d3:: with SMTP id i19mr2472155oto.71.1579592132258; Mon, 20 Jan 2020 23:35:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579592132; cv=none; d=google.com; s=arc-20160816; b=pTQpMTa15ML+24ttD/N/M0romOtm8FAG0TNH9tS7t6EMV38J1vk3mdq6Rlw7LR3y5I bXlhX5QGHNayNSYwrl10a3ddkVJRa7GmyXTUsFRd4QKWvasdJr1gi1TXeKJTV7DmPu82 KOsjLkkSRFbOX/iNuiCZoUAXTQ9xiDeka1BBE3Lgn5AtTlL3mHyKIqqlh3M+fvL0JfXJ f7TFdsle1wUpIxxXZxclVETqNV0hahj//VZ03E5PeRZ6dnhruGU3x18KCUCY/4T5CMM+ S7TFxOXwiARr90DCAgi1QQCUAb3R7H3zmwMbBcj9h6KU+aHgxaKl6D/OuBdCBhB6WG35 zy+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from; bh=ML5oQRi228OPzdwB/3iRI3ZzvqorGde6MbRdvaELjtw=; b=GjnYmGz1i3bXfMXBQkLnkshkVHikaSRV89Qa2sTUAIFzs+4u4tcUjGRrqZZL8ebwaY K0rj19WzTYfM70ra53upuyx830jtECqJT420xn3qdPxHJf0IgpqpQzWxZ5pqU8WMaMbN bIBDJNHxah3rIlb4OJGM3Mx12mFVEH67Rap38BLd+UTnRKaG2DTceuPl0VLItbTzuwax KDxecrW3W+wh4HmlTA0TALAzOU4qCkH/z6yymj2eAFrr/vTHUwtZ9Ozb4nxS9CSq1s+u LbfiSa0sdJ5SShtg9B6g6khTc9BJQK5HIgmbKYjaQWQvCNBjlzqyfLJ2vSGJQxpBjRQ3 GnaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z12si23585883otm.189.2020.01.20.23.35.19; Mon, 20 Jan 2020 23:35:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728852AbgAUHe1 (ORCPT + 99 others); Tue, 21 Jan 2020 02:34:27 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:51053 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbgAUHe0 (ORCPT ); Tue, 21 Jan 2020 02:34:26 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0ToHCg0j_1579592053; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0ToHCg0j_1579592053) by smtp.aliyun-inc.com(127.0.0.1); Tue, 21 Jan 2020 15:34:13 +0800 From: Alex Shi Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] btrfs/raid56: remove unused actions Date: Tue, 21 Jan 2020 15:34:10 +0800 Message-Id: <1579592050-86280-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No one care p_stripe in its functions. Guess it's safe to remove. Signed-off-by: Alex Shi Cc: Chris Mason Cc: Josef Bacik Cc: David Sterba Cc: linux-btrfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/btrfs/raid56.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c index a8e53c8e7b01..fbee5681e690 100644 --- a/fs/btrfs/raid56.c +++ b/fs/btrfs/raid56.c @@ -1196,7 +1196,6 @@ static noinline void finish_rmw(struct btrfs_raid_bio *rbio) int nr_data = rbio->nr_data; int stripe; int pagenr; - int p_stripe = -1; int q_stripe = -1; struct bio_list bio_list; struct bio *bio; @@ -1204,14 +1203,10 @@ static noinline void finish_rmw(struct btrfs_raid_bio *rbio) bio_list_init(&bio_list); - if (rbio->real_stripes - rbio->nr_data == 1) { - p_stripe = rbio->real_stripes - 1; - } else if (rbio->real_stripes - rbio->nr_data == 2) { - p_stripe = rbio->real_stripes - 2; + if (rbio->real_stripes - rbio->nr_data == 2) q_stripe = rbio->real_stripes - 1; - } else { + else BUG(); - } /* at this point we either have a full stripe, * or we've read the full stripe from the drive. -- 1.8.3.1