Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0
To:     Chen Zhou <chenzhou10@huawei.com>, davem@davemloft.net,
        mhabets@solarflare.com, kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200121013553.15252-1-chenzhou10@huawei.com>
From:   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <40eb3815-f677-c2fd-3e67-4b39bb332f48@cogentembedded.com>
Date:   Tue, 21 Jan 2020 11:39:05 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200121013553.15252-1-chenzhou10@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello!

On 21.01.2020 4:35, Chen Zhou wrote:

> Fixes coccicheck warning:
> 
> ./drivers/net/ethernet/amd/declance.c:611:14-15:
> 	WARNING comparing pointer to 0
> 
> Compare pointer-typed values to NULL rather than 0.

    I don't see NULL in the patch -- you used ! instead.

> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
>   drivers/net/ethernet/amd/declance.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
> index 6592a2d..7282ce5 100644
> --- a/drivers/net/ethernet/amd/declance.c
> +++ b/drivers/net/ethernet/amd/declance.c
> @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
>   			len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
>   			skb = netdev_alloc_skb(dev, len + 2);
>   
> -			if (skb == 0) {
> +			if (!skb) {
>   				dev->stats.rx_dropped++;
>   				*rds_ptr(rd, mblength, lp->type) = 0;
>   				*rds_ptr(rd, rmd1, lp->type) =

MBR, Sergei