Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3456153ybl; Tue, 21 Jan 2020 00:50:18 -0800 (PST) X-Google-Smtp-Source: APXvYqwsg2njPAMImwP5X5Aj0kzAVffqFiKTrJcJMNanpwj/BW4e9NUfNSRgIFsr2AyF4VhYp3mJ X-Received: by 2002:aca:d484:: with SMTP id l126mr2136443oig.114.1579596618267; Tue, 21 Jan 2020 00:50:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579596618; cv=none; d=google.com; s=arc-20160816; b=zcoiMfKrld0iXotgo7sWWJukN5hRaJzYDy81YQ+Wpx8CPm51sZCQIJubHF0zVr8VPX EJ+PbkDfwjP0SVEg2hDW79lMgNQ0DI47sp1pZ1hvewQS4aWXqcUxosv1qLCnCLhlcSh/ lKkFU2PYe+r5+hDNl2iMRV9oMZB3s8cb/vy6ZPCt6LlQSdNhBnG6ntRTfMXTFUU/7WOb /p/6IFJbrhaJ6W7lvaq9xmwYeKmFXA/Dej2GZzW7Z8Ue6YD3tUDBpdtdI7u5Q1erU31h OsbtO6MkchdAgh0ARLmrTuYiQqE9Wjkhyb8QTxc6ZtlhZaDSrEldEAxtDyRHnlaPunvC HH4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from; bh=fFZmkT3EGMz+dinpkJWn1viUIRsXPRrawN2o+rfYpL4=; b=w6c4+XpYXvtT42WCDMX+ZyjIkR8Z8F3L12U6OG5fjfjXijZdn3gdjS0d0jaGeNQoaE wzuycRSZcMdjYeTqTdGNvx12xNWsXkp9+dJx8k0fwGjEjc7Ep8rAGKKaKOzqNDD2cW6l 7mMWmZ3bBfl3Hi30kuitCNy3UyHxQzqVmGo94tP8IyRrshxFn4HzQuALtioFkFLfQ8/I URYneuipPdGQMaa5BFNVmKntSaZo/CjJ1xbj4c9XcYnw2YPF83Ay/pivH9rX4Q3V4AOs wsgvKXeUCWGuh/AuPlUsQeQNwgjATGzyV7pGrCZh68VImN7eDuS8UrMhazZSHBOfSySU qEbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m20si22147007otk.279.2020.01.21.00.50.06; Tue, 21 Jan 2020 00:50:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729008AbgAUItE (ORCPT + 99 others); Tue, 21 Jan 2020 03:49:04 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:39057 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728977AbgAUItE (ORCPT ); Tue, 21 Jan 2020 03:49:04 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R801e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04446;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0ToHWsYi_1579596541; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0ToHWsYi_1579596541) by smtp.aliyun-inc.com(127.0.0.1); Tue, 21 Jan 2020 16:49:01 +0800 From: Alex Shi Cc: Jan Harkes , coda@cs.cmu.edu, codalist@coda.cs.cmu.edu, linux-kernel@vger.kernel.org Subject: [PATCH] coda: remove err which no one care Date: Tue, 21 Jan 2020 16:48:59 +0800 Message-Id: <1579596539-257694-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No one care 'err' in func coda_release, so better remove it. Signed-off-by: Alex Shi Cc: Jan Harkes Cc: coda@cs.cmu.edu Cc: codalist@coda.cs.cmu.edu Cc: linux-kernel@vger.kernel.org --- fs/coda/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/coda/file.c b/fs/coda/file.c index 128d63df5bfb..31a7ba383cb2 100644 --- a/fs/coda/file.c +++ b/fs/coda/file.c @@ -238,11 +238,10 @@ int coda_release(struct inode *coda_inode, struct file *coda_file) struct coda_file_info *cfi; struct coda_inode_info *cii; struct inode *host_inode; - int err; cfi = coda_ftoc(coda_file); - err = venus_close(coda_inode->i_sb, coda_i2f(coda_inode), + venus_close(coda_inode->i_sb, coda_i2f(coda_inode), coda_flags, coda_file->f_cred->fsuid); host_inode = file_inode(cfi->cfi_container); -- 1.8.3.1