Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3486549ybl; Tue, 21 Jan 2020 01:31:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwvrOS4I8wYxRyOVpwwWZle42Jczu4jqk3s0CxJpC1W5QMgiknixw56SkWNEg9V9GoGsGqB X-Received: by 2002:a9d:6849:: with SMTP id c9mr3074541oto.206.1579599064801; Tue, 21 Jan 2020 01:31:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579599064; cv=none; d=google.com; s=arc-20160816; b=tWKMny71fYhbeYo3+Z5Bv/O6Z/sP4YPCHiwaksrlzygbW9j3h+zH6wjUH2mprqM4Va F1agaUi4ga+wCwg5AWohYIkKOmij7hSGxbOWdtu8/1sYM5o2TPeyAoYUKUh8lNmlIUoh eghlz8R+lsTQawW3UHtUiF344/ul5g1CgZvESv/UiXQ/mPqo5pt57g4+0E66JcmsJWuO scwAPQtH56l6QZpII0S9vlDQe0y9IMtcGEZpIqpEfHXsEApskeZRhXNQx7KJKa3TJl5R 9DPduZOX9p0Ag2kDvpmaOcFoiOqeo4b5nEWGZjDGhsltGX6ob+YetrQMCQYy681Pbw4f Mpqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=UX3/vvWP/ugznqpKSsthoDlMu/+yo5a/xW9eTF95NEs=; b=fL5jr6J41PKnqpsHVByULKtw+3vy2y2kqTHuwYu+67I3jZoNjVKyPoFXGphZyiTqPS NmC/ro6VaeIFUgSt9+4X7QRTz4hNnFRX6cJMpmNrNY79CSWO9KcpurFYuqVgoFm6AaNa IUwix5fk+MiL7E1WMP9meVqLBuUYvRtuXre2cXL4trrvDh1kUWGCPlR5d3HPfSMIfMkC 250h6LrT7UMkLhKCdHGn8phrZ3jM7a6pKmFlCfqv8bB07uAAmV3xxyYiyDGfq4gujJfh vLXOWAolTD25N5VA2eJPcVCgjTO/KTVA6PoO/Us690/atIpc9zr3DI0nW5J1hocSIofK glZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8si18697707oia.262.2020.01.21.01.30.52; Tue, 21 Jan 2020 01:31:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728978AbgAUJaC (ORCPT + 99 others); Tue, 21 Jan 2020 04:30:02 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:10121 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727220AbgAUJaB (ORCPT ); Tue, 21 Jan 2020 04:30:01 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 77E63953C003BFDE2BD5; Tue, 21 Jan 2020 17:29:59 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Tue, 21 Jan 2020 17:29:48 +0800 From: Chen Zhou To: , , , CC: , , Subject: [PATCH -next v2] drivers: net: declance: fix comparing pointer to 0 Date: Tue, 21 Jan 2020 17:24:55 +0800 Message-ID: <20200121092455.82983-1-chenzhou10@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes coccicheck warning: ./drivers/net/ethernet/amd/declance.c:611:14-15: WARNING comparing pointer to 0 Replace "skb == 0" with "!skb". Signed-off-by: Chen Zhou --- drivers/net/ethernet/amd/declance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c index 6592a2d..7282ce5 100644 --- a/drivers/net/ethernet/amd/declance.c +++ b/drivers/net/ethernet/amd/declance.c @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev) len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; skb = netdev_alloc_skb(dev, len + 2); - if (skb == 0) { + if (!skb) { dev->stats.rx_dropped++; *rds_ptr(rd, mblength, lp->type) = 0; *rds_ptr(rd, rmd1, lp->type) = -- 2.7.4