Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3498271ybl; Tue, 21 Jan 2020 01:47:46 -0800 (PST) X-Google-Smtp-Source: APXvYqw8Jp7vw7/6tt8k5HK1moKEIE8kKtUk8fvkOXgCCreG5+HT7TQOv6Tl8Y0RMGhsDza1LhHT X-Received: by 2002:a05:6808:618:: with SMTP id y24mr2250287oih.86.1579600066064; Tue, 21 Jan 2020 01:47:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579600066; cv=none; d=google.com; s=arc-20160816; b=Gbt9RFrqVijRLvbwXZUv2fZWEec9+OUVsU3hoM7qDlIXDrOEVFvr6oRc/aqD6uD6up PII60KlfozcwOLRjqLBoU0p7rMMy7kSzBR7xpMsPlUVol9W0h7IHYUNxpFsHYWzlmS0Q UxK7kJE3lfASP+GA48w5cIab+8FsLg5v/pEBOBfHvcGv1lxZrsIALchhlit0kOu4jCiB /VdpvbIorMYNwQbMev2txlyiOluYdJLyCZNs9+2ilTCkPdpkVPBO3c4e+ilsT8Vv5PDl ZPhhkkOyweVScFAle08CYzxd2JvDvV4QzTVF0pUiggALQI7NoMgB1sUKBD+hBxp6uGon Ag6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=+gUuoGCR7q28pIKAWPwMsgIo64uELnx9sqr1lFX9/Bw=; b=zwE3JADnA2xHczOpolwypHrK1ITC+wEcHGZPz3FRfnLTRgiYNYPH/gkN5CarDUEd/f LRGWIqVNahX7vhljFDZTaHWJKD+wM/jIR6Fuq9VJjoj9UcyKF2xOMFImNsgfyWrEE32Q OmxagAzuKWCHMb+szAj/Tfmdg7yE/iGC32NYB5Fp7+Vi2jRE9sCQasyK/uDpo6JkqTb+ wSDjBSQIzLVzKYe3qWKC+t7opT2GR1NFYDAYAGgX/YnKlshTi03BQU092GezCOqzZsUw wmfoKl9u2v4B3P9IM2IeY/jvhpQz6zcXhT9DP2xsbLQNUTHUAS5RQxiRilmG9NVjMfUp kc9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si21937797oto.204.2020.01.21.01.47.33; Tue, 21 Jan 2020 01:47:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728842AbgAUJqj (ORCPT + 99 others); Tue, 21 Jan 2020 04:46:39 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:35854 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbgAUJqi (ORCPT ); Tue, 21 Jan 2020 04:46:38 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C5A1115BBD4F6; Tue, 21 Jan 2020 01:46:36 -0800 (PST) Date: Tue, 21 Jan 2020 10:46:35 +0100 (CET) Message-Id: <20200121.104635.663739014554850228.davem@davemloft.net> To: wenyang@linux.alibaba.com Cc: edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tcp_bbr: improve arithmetic division in bbr_update_bw() From: David Miller In-Reply-To: <20200120100456.45609-1-wenyang@linux.alibaba.com> References: <20200120100456.45609-1-wenyang@linux.alibaba.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 21 Jan 2020 01:46:38 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang Date: Mon, 20 Jan 2020 18:04:56 +0800 > do_div() does a 64-by-32 division. Use div64_long() instead of it > if the divisor is long, to avoid truncation to 32-bit. > And as a nice side effect also cleans up the function a bit. > > Signed-off-by: Wen Yang Applied, thank you.