Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1579596552-257820-1-git-send-email-alex.shi@linux.alibaba.com>
In-Reply-To: <1579596552-257820-1-git-send-email-alex.shi@linux.alibaba.com>
From:   =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= <andreas.gruenbacher@gmail.com>
Date:   Tue, 21 Jan 2020 11:23:35 +0100
Message-ID: <CAHpGcMJ6DazJ_rMPB2uUKfH-1oxVy=RoLvt2nMEvcdWWCnWjDw@mail.gmail.com>
Subject: Re: [PATCH] fs/gfs2: remove IS_DINODE
To:     Alex Shi <alex.shi@linux.alibaba.com>
Cc:     Bob Peterson <rpeterso@redhat.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        cluster-devel <cluster-devel@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Alex,

Am Di., 21. Jan. 2020 um 09:50 Uhr schrieb Alex Shi
<alex.shi@linux.alibaba.com>:
> After commit 1579343a73e3 ("GFS2: Remove dirent_first() function"), this
> macro isn't used any more. so remove it.
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Bob Peterson <rpeterso@redhat.com>
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: cluster-devel@redhat.com
> Cc: linux-kernel@vger.kernel.org
> ---
>  fs/gfs2/dir.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index eb9c0578978f..636a8d0f3dab 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -74,7 +74,6 @@
>  #include "util.h"
>
>  #define IS_LEAF     1 /* Hashed (leaf) directory */
> -#define IS_DINODE   2 /* Linear (stuffed dinode block) directory */

The same is true for the IS_LEAF macro. I'm adjusting the patch accordingly.

The other patch removing the LBIT macros looks good as well, so I'm
applying both.

Thanks,
Andreas