Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3531494ybl; Tue, 21 Jan 2020 02:30:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxhdV8QE6orzz7mPMS2xO74Y1DJyZOeCmaY9iz+fBjPCoZHD/FQud24sHi/fMxmS8zhAhK4 X-Received: by 2002:aca:c256:: with SMTP id s83mr2481554oif.57.1579602627093; Tue, 21 Jan 2020 02:30:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579602627; cv=none; d=google.com; s=arc-20160816; b=s7LtknbjIBdpXFwo03GWVuNd/aSma07FJV+KLeN+SSTSKQjVIHc9/NrVlR0EDxEHrH pKJy3h9Jbf1GharhjMAkXjta2qA2e1iVXgkp85dY/lwZYAfizcspjE9rHTxfMFO9p/Ic 0Uwh4SA4AS8zAKiY18HCwsPotja4zaM8fi4cuZ+HrCBfCoHz68cBO61mCu13GSfXzRIk bAgYg1TmFuvRL831tg5Gh5ncA6aJboewQvezkl9/sIre8Hdh2EqUSwohEMDVUn8OTsjR m9e0KlKoTXsTu41yTVGHsZemxVp1qZN0PLwPLJkZ1doz/wyDm6KNiJoZZJIak5CRNDLO YlWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=xTHoRzceQRzEGzLjGQcVpKJYBI7timpYO83DpycWnMA=; b=sCmN/Nnm24+J7hhZhWiN+kSSUHN4ILbn6r+8Dow6TRiAoodxB1rXpffHK5CetbMZqw 5cj1SCbsBt6ATNDfvymdFk/lVXDfqy7iuUtkeO9NufsYoFaBVacgokFINMJrMnbLE+z2 eTiUSlcAp/VbElw+J+kMoB2xx3icU7jysgvm4n9hHsUAr07fcAzMVxjBWDqn7+pInXGt Tf23xh+i7BJylwPJWn4chpd5IC1NLCVV1/0Udu3Db9R0Rd/3NwPYtnEE3NOxpuyh5WPB Ml4vGfraKNJ0eVIU5hUyb0R0xF6etrVEI5ULNPuy5HbkrnQEatSrU8eXPCgNvNa7F7CU P6sA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e22si21880340otj.38.2020.01.21.02.30.15; Tue, 21 Jan 2020 02:30:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729416AbgAUK2P (ORCPT + 99 others); Tue, 21 Jan 2020 05:28:15 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:53626 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728931AbgAUK2P (ORCPT ); Tue, 21 Jan 2020 05:28:15 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R991e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04396;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0ToHg3hQ_1579602492; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0ToHg3hQ_1579602492) by smtp.aliyun-inc.com(127.0.0.1); Tue, 21 Jan 2020 18:28:13 +0800 Subject: Re: [PATCH] fs/gfs2: remove IS_DINODE To: =?UTF-8?Q?Andreas_Gr=c3=bcnbacher?= Cc: Bob Peterson , Andreas Gruenbacher , cluster-devel , Linux Kernel Mailing List References: <1579596552-257820-1-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: Date: Tue, 21 Jan 2020 18:26:24 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/1/21 下午6:23, Andreas Grünbacher 写道: > Alex, > > Am Di., 21. Jan. 2020 um 09:50 Uhr schrieb Alex Shi > : >> After commit 1579343a73e3 ("GFS2: Remove dirent_first() function"), this >> macro isn't used any more. so remove it. >> >> Signed-off-by: Alex Shi >> Cc: Bob Peterson >> Cc: Andreas Gruenbacher >> Cc: cluster-devel@redhat.com >> Cc: linux-kernel@vger.kernel.org >> --- >> fs/gfs2/dir.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c >> index eb9c0578978f..636a8d0f3dab 100644 >> --- a/fs/gfs2/dir.c >> +++ b/fs/gfs2/dir.c >> @@ -74,7 +74,6 @@ >> #include "util.h" >> >> #define IS_LEAF 1 /* Hashed (leaf) directory */ >> -#define IS_DINODE 2 /* Linear (stuffed dinode block) directory */ > > The same is true for the IS_LEAF macro. I'm adjusting the patch accordingly. > I oversee this. Sorry. > The other patch removing the LBIT macros looks good as well, so I'm > applying both. Thanks a lot! Alex