Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3542040ybl; Tue, 21 Jan 2020 02:43:16 -0800 (PST) X-Google-Smtp-Source: APXvYqz6+Ro5wPfTmhe9ZZ7wdNv2+go5WSpcW5Ivdr0NT126UjKS74RheOkJzazt/2QPtsDn0IXp X-Received: by 2002:a05:6830:2099:: with SMTP id y25mr2860664otq.87.1579603396860; Tue, 21 Jan 2020 02:43:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579603396; cv=none; d=google.com; s=arc-20160816; b=OB1EvZgzJz3+bW2vqTAKbRrn1Tf2CfE/gdwW3OFpJFB6JrY3FctqRVTfP4jQgjjfca koOt6IGI8mmlYrLV01D+OH7et2sW8X5CcN3OUC7DJRzPTC5q2uLRAmtyAR2IvWpNRznG vffqzeLJIwMd8hjWFjQfOEa+2OYoto/Nexx3KRtpA7jcxRAXT1QNnTA/+S6rWsjdfs3d 2GfxrYxe73kFECN2hCokEDcezrVOhoW1t/LXlR5BZifusX5kmvuPWGF9rKBhFiZXfz81 +CPRu0osmiQc3lw1YSqZ3+lSYR9GF97eqzuMJSlYGUelyu8n8svDpnMrzC5cWJwqGqKT AaGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=tqTBSH6/hlISiOSw3y/zDtEGc/64hyiNa9b7lPyl+NE=; b=MB+7b69yKa7p/4hd59Ie8yCZts6slHy34cZebwINn1A8bbdNzK0AwOx4BQ/jguMhsz BmT4n/gCJTR/X0+nB0ph4G0V2zXiaEiQ0rom31BkeGMqHgcWKTTtpmNuHPVzkfif+MD2 TGjFr4sH+Aptw3J7vr1JNmoxC41JeKLjQNKWTg4H+uvWCqG6HDFf/lVOUAx9TDoctLZm n1uQBsYsBtRYPqn0A89x4pZf+CrWj/cFxDK7K5NmbD/KFCrqL1EhSalUmoRdRkHsNP5e Gg23Er80j1Dggfxy4BmqL4TIK1xiKj+E9EoPhL5HrltV1J35egzZFYf/E6Qb4GkjsSdB hOhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si18809135oic.225.2020.01.21.02.43.05; Tue, 21 Jan 2020 02:43:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729596AbgAUKmD (ORCPT + 99 others); Tue, 21 Jan 2020 05:42:03 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36160 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728831AbgAUKmD (ORCPT ); Tue, 21 Jan 2020 05:42:03 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4684F15BF7DCF; Tue, 21 Jan 2020 02:42:01 -0800 (PST) Date: Tue, 21 Jan 2020 11:41:59 +0100 (CET) Message-Id: <20200121.114159.2274824592420675035.davem@davemloft.net> To: ms@dev.tdt.de Cc: kubakici@wp.pl, khc@pm.waw.pl, linux-x25@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] wan/hdlc_x25: fix skb handling From: David Miller In-Reply-To: <20200121060034.30554-2-ms@dev.tdt.de> References: <20200121060034.30554-1-ms@dev.tdt.de> <20200121060034.30554-2-ms@dev.tdt.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 21 Jan 2020 02:42:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Martin Schiller Date: Tue, 21 Jan 2020 07:00:34 +0100 > o call skb_reset_network_header() before hdlc->xmit() > o change skb proto to HDLC (0x0019) before hdlc->xmit() > o call dev_queue_xmit_nit() before hdlc->xmit() > > This changes make it possible to trace (tcpdump) outgoing layer2 > (ETH_P_HDLC) packets > > Additionally call skb_reset_network_header() after each skb_push() / > skb_pull(). > > Signed-off-by: Martin Schiller Applied to net-next