Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] ata: pata_macio: fix comparing pointer to 0
To:     Chen Zhou <chenzhou10@huawei.com>
Cc:     axboe@kernel.dk, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Message-ID: <ce9dbc1d-0f48-da24-af56-74a93f964e3a@samsung.com>
Date:   Tue, 21 Jan 2020 11:58:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200121012827.1036-1-chenzhou10@huawei.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20200121013332eucas1p223fe0dd6da9ac002f3d5dd152d4ea7a8@eucas1p2.samsung.com>
        <20200121012827.1036-1-chenzhou10@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/21/20 2:28 AM, Chen Zhou wrote:
> Fixes coccicheck warning:
> 
> ./drivers/ata/pata_macio.c:982:31-32:
> 	WARNING comparing pointer to 0, suggest !E
> 
> Compare pointer-typed values to NULL rather than 0.
> 
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/ata/pata_macio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index 1bfd015..e47a282 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -979,7 +979,7 @@ static void pata_macio_invariants(struct pata_macio_priv *priv)
>  	priv->aapl_bus_id =  bidp ? *bidp : 0;
>  
>  	/* Fixup missing Apple bus ID in case of media-bay */
> -	if (priv->mediabay && bidp == 0)
> +	if (priv->mediabay && !bidp)
>  		priv->aapl_bus_id = 1;
>  }
>