Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3566019ybl; Tue, 21 Jan 2020 03:11:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxC8zfd1eaOJzdG3fWpgz8ZnRQz9UpONxjo8VUre5Ze1psiDx/pLFnzgU9tZaxIrMAe85tA X-Received: by 2002:a9d:3d0a:: with SMTP id a10mr3165826otc.327.1579605091787; Tue, 21 Jan 2020 03:11:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579605091; cv=none; d=google.com; s=arc-20160816; b=RCS//KmMLJEvplLaL3fMr+Ah3DSFWtqQlQbneByZyMNzYyfbwUZPuNue40pJgiHiuv n0ZTzUgBCa5zZn6DTy+a3Xt+T/NRSL6EHUz0Qqi5c8oN81Vk2SEqzYEXunjm2qRd3XHL OEXiMpqHex3bZ4Q5opsoakjicHHfHhO6RONfVyq1WlBrB7qZpz9GrLRmj+e8DIMzGAsL ro4Qr85Jdre76Keu4V+T/3bXljC2MFf9gZDjxXR3AqX4tqweulRD3mxIcK8WKwmfjhay Tk7OCHTR0rjYdA+UjXW+5p004xCA0+5rdBUPIykeMR6qI8moPi2f97KX6Z0Z6mApR6tZ jcGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=as1Ml2ce0AAqxyFo2q5Y8g+VhLygOAxyNcrI5l3ZKiw=; b=E2CPfajnaU3WsqLKzg4LD5yGoGKzgeu+jmoiIg0SnMV2lRvxyRnu/Epwy0B5+Ldp9F YTlDa24QNkRNvgHJHJQNEZuehR2tRyDiR9FfF7tDI0YjIIGm09Fyv4+vYUQb3AbQdkwJ v1X+dmvLnnIHprprh5uu3ZdAkIipBWMlUEYJzRvH31g6sdf2XpE3ZdyBYvJ1820CQA8r MBsU57qUPJzTiyV9e2YU7aRUqnAmd2cN2pd7JmT3oXgUxQ18srMOKsYl9Z9xT3mIZyI8 SxFDza9UCXicqiKmn4CTKKWBqwZN8fe7KFw770uEnt/FaZMsl2XOGWKz6OAmzFcT7Qah /MQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si12010982otk.134.2020.01.21.03.11.20; Tue, 21 Jan 2020 03:11:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729174AbgAULKV (ORCPT + 99 others); Tue, 21 Jan 2020 06:10:21 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36316 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbgAULKU (ORCPT ); Tue, 21 Jan 2020 06:10:20 -0500 Received: from localhost (82-95-191-104.ip.xs4all.nl [82.95.191.104]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F240915C1D7B3; Tue, 21 Jan 2020 03:10:18 -0800 (PST) Date: Tue, 21 Jan 2020 12:10:17 +0100 (CET) Message-Id: <20200121.121017.935276956491301331.davem@davemloft.net> To: chenzhou10@huawei.com Cc: mhabets@solarflare.com, kuba@kernel.org, sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v2] drivers: net: declance: fix comparing pointer to 0 From: David Miller In-Reply-To: <20200121092455.82983-1-chenzhou10@huawei.com> References: <20200121092455.82983-1-chenzhou10@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 21 Jan 2020 03:10:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen Zhou Date: Tue, 21 Jan 2020 17:24:55 +0800 > Fixes coccicheck warning: > > ./drivers/net/ethernet/amd/declance.c:611:14-15: > WARNING comparing pointer to 0 > > Replace "skb == 0" with "!skb". > > Signed-off-by: Chen Zhou Applied, thanks.