Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/iperm: remove unused pointers
To:     Alex Shi <alex.shi@linux.alibaba.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        linux-kernel@vger.kernel.org
References: <1579596054-254032-1-git-send-email-alex.shi@linux.alibaba.com>
From:   Waiman Long <longman@redhat.com>
Organization: Red Hat
Message-ID: <4c29cfaa-6b86-aeb5-7d81-f1f663f6f154@redhat.com>
Date:   Tue, 21 Jan 2020 09:16:01 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <1579596054-254032-1-git-send-email-alex.shi@linux.alibaba.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/21/20 3:40 AM, Alex Shi wrote:
> No one use the prev/next pointers in its function after commit 22fe5b0439dd
> ("x86/ioperm: Move TSS bitmap update to exit to user work"). So better to
> remove them.
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Thomas Gleixner <tglx@linutronix.de> 
> Cc: Ingo Molnar <mingo@redhat.com> 
> Cc: Borislav Petkov <bp@alien8.de> 
> Cc: "H. Peter Anvin" <hpa@zytor.com> 
> Cc: x86@kernel.org 
> Cc: Andy Lutomirski <luto@kernel.org> 
> Cc: Rik van Riel <riel@surriel.com> 
> Cc: Dave Hansen <dave.hansen@intel.com> 
> Cc: Waiman Long <longman@redhat.com> 
> Cc: Marcelo Tosatti <mtosatti@redhat.com> 
> Cc: linux-kernel@vger.kernel.org 
> ---
>  arch/x86/kernel/process.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 61e93a318983..839b5244e3b7 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -615,12 +615,8 @@ void speculation_ctrl_update_current(void)
>  
>  void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p)
>  {
> -	struct thread_struct *prev, *next;
>  	unsigned long tifp, tifn;
>  
> -	prev = &prev_p->thread;
> -	next = &next_p->thread;
> -
>  	tifn = READ_ONCE(task_thread_info(next_p)->flags);
>  	tifp = READ_ONCE(task_thread_info(prev_p)->flags);
>  

Acked-by: Waiman Long <longman@redhat.com>