Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3822168ybl; Tue, 21 Jan 2020 07:39:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzSn4HmqFcMYoQPx3VrkyND2jcajWuLMrRtSFhx7fQbFXBlPlAhobfkzk/IPyXSzYLJaa34 X-Received: by 2002:a05:6808:1c5:: with SMTP id x5mr3485816oic.57.1579621183443; Tue, 21 Jan 2020 07:39:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579621183; cv=none; d=google.com; s=arc-20160816; b=b37BxmLGqMhSV4pv8mSK46BPPWUQh8N5yDxYnnOWIqBhmF0Sqf1Fb+OZQ7caa9F4+W bCvqDjQQy25tXoFuA5d/Jhplho1VfLkl7WVweHNnPdx1u2+oiOx/Tbgdd0iPxLmwp/zo S5TpiBiZt7Fw6ztU02xCi31EDN57ODLEMERls/9T7SxszxLVqCWiivtVFEtO/PZKnc6T 5cZI6PuA0ppO6Wf+BRB6CnqL/8c9vm/77+oWM/RoGJW4gnJQ4jtDSbDZ/7WMdb2C+9OV ECcDKOxzi3pEWauZHPRZBjeNrZEy2MrSq2YI4xtNkiDhbjsdYOWpo6Bv1ZJ46u0MzTLm Xydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RmViYAa1rRPt72/wIccYehar/+HNwKCjcTf+igUl6VA=; b=cRLLddJt3abXWz7PIeKHJllXp/hWgN6YadkjJPSWCSerecuo3jjetNTQ8ndPovI0Vf 6EORl395X+CORjyPKwllD4Z7Eo3m2GK/J+ay1+8kzgLROvHRDGNQjsvgZQPRhX8cXc12 AqeDT6b4UbtyDKHKLm9Um2LcZGq8srgHBEHzHgkyxQanUxSZ1hnRS54Rq4JXVYGcRLZB h8/CiRMha8uZJRWWgQ4E10HiOtCYw/7Y7AKs8BnhSkLleqrf0FJS0REeefzVh13VjFoG H4cn+q6J1aFM29oZPK1jI6KqFun2a191mjhHpTOHE8Pdu5vo+rTGKX8OXtxBE6unevgk T+fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="fh+L/HgW"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y140si20069263oia.49.2020.01.21.07.39.30; Tue, 21 Jan 2020 07:39:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="fh+L/HgW"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729174AbgAUPhC (ORCPT + 99 others); Tue, 21 Jan 2020 10:37:02 -0500 Received: from mail-oi1-f178.google.com ([209.85.167.178]:43259 "EHLO mail-oi1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgAUPhB (ORCPT ); Tue, 21 Jan 2020 10:37:01 -0500 Received: by mail-oi1-f178.google.com with SMTP id p125so2901527oif.10 for ; Tue, 21 Jan 2020 07:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RmViYAa1rRPt72/wIccYehar/+HNwKCjcTf+igUl6VA=; b=fh+L/HgWv3D9ttnggU6JGqSQStDK5h3ktOJkYmdzLKBOJ9Iqsa+rnenXs+L7x9noRb yMJZgzsETDV0BK+WrUpmkr8t8pLkm/0XpC4tPvC88sMPcN30eVKswEi9iIY8M1OOedSx r6Ux/4FHN44flxoqAmMDp+172AbujOl8cYd9hXmQDpvmNOaAG/HZVSAyAd+QWunblMIE dCyDRMzerFinT5IJe3xbo/pr58qOHuZ9TTe8P6Vkm2Asvz/aqqFLTZ+3x1L8hvwq0LDJ AYndPKkW/Y/T9tjiN2/8CTbyHu/VMWEGbj70+my8Y//1mLgdiH+BNz6c631UisVP+T1A gaTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RmViYAa1rRPt72/wIccYehar/+HNwKCjcTf+igUl6VA=; b=lk5apzTLjPXG5zbg7wKdUrTmV2gph/Wvq1RTL+ci6HrPVMRh75csfFAAUpzxPyBmD+ mZpJqnXNbrcal1SS/t82jiBgaMhqyPQQsP99yQHa4rQr94V+oc8RTl9NF8UqYaj4L4Jy DzONMlPa6Esg6wz1HvnOMWyN/XZCA3QiOmoQqA11QuzGy2khjV3p3RZFdrRbDispeSLU p6fCmHuuK055cM1lGn5nMP289flTgAtyx/fdN9z2MQAdgZ5HHTj6ZpsFX0mhyATlBXas uUV2HT5XC6+hxvCyBatdV+izJPiawuRLp3LPr8vU5XwWa78Hc5HI20uC8/j/5Svtmt5A PpdA== X-Gm-Message-State: APjAAAVnzvcHBo1rirjdEIq/oY8b73YDbviEQaBRRNXJO6PJV41Zz/XY Vi2WSefHTjDYv4YJWQJDKUZ1B0tHdlAhSD4TPg5YXQ== X-Received: by 2002:a05:6808:8d5:: with SMTP id k21mr3542611oij.121.1579621020494; Tue, 21 Jan 2020 07:37:00 -0800 (PST) MIME-Version: 1.0 References: <20200121151503.2934-1-cai@lca.pw> <20200121152853.GI7808@zn.tnic> <44A4276D-5530-4DAA-8FC7-753D03ADD2F3@lca.pw> In-Reply-To: <44A4276D-5530-4DAA-8FC7-753D03ADD2F3@lca.pw> From: Marco Elver Date: Tue, 21 Jan 2020 16:36:49 +0100 Message-ID: Subject: Re: [PATCH -next] x86/mm/pat: silence a data race in cpa_4k_install To: Qian Cai Cc: Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , Andy Lutomirski , Peter Zijlstra , "the arch/x86 maintainers" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jan 2020 at 16:33, Qian Cai wrote: > > > > > On Jan 21, 2020, at 10:28 AM, Borislav Petkov wrote: > > > > On Tue, Jan 21, 2020 at 04:19:22PM +0100, Marco Elver wrote: > >> Could you remove the verbatim copy of my email? Maybe something like: > >> > >> "Increments to cpa_4k_install may happen concurrently, as detected by KCSAN: > >> > >> <....... the stack traces ......> > > > > ... and drop the stack traces and fix your subject to say what you're > > actually "fixing". > > Does this title work for you? > > x86/mm/pat: silence an data race for KCSAN Isn't the intent "x86/mm/pat: Mark intentional data race" ? The fact that KCSAN no longer shows the warning is a side-effect. At least that's how I see it. Thanks, -- Marco