Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver
To:     Jon Hunter <jonathanh@nvidia.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Thierry Reding <thierry.reding@gmail.com>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, Jeff Brasen <jbrasen@nvidia.com>
References: <20200120160149.29072-1-jonathanh@nvidia.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <f02faa4c-5838-15d2-1b76-75c17fcc0d9d@gmail.com>
Date:   Tue, 21 Jan 2020 19:31:35 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <20200120160149.29072-1-jonathanh@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Jon,

20.01.2020 19:01, Jon Hunter пишет:

[snip]

> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -ENODEV;
> +
> +	port->membase = devm_ioremap(&pdev->dev, res->start,
> +				     resource_size(res));

devm_platform_ioremap_resource()

> +	if (!port->membase)
> +		return -ENOMEM;
> +
> +	port->mapbase = res->start;
> +	port->mapsize = resource_size(res);
> +
> +	uart->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);

Why reset is shared? It shall not be shared at least on T20/30/124/210..

[snip]