Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3904684ybl; Tue, 21 Jan 2020 09:09:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwavAxJi8hB7YujK7rSrEKfDlJkS8XzcwzBdilKeRmTEw3K5iyofKLIyerOKlWfryjjELq7 X-Received: by 2002:aca:4106:: with SMTP id o6mr3746933oia.173.1579626588905; Tue, 21 Jan 2020 09:09:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579626588; cv=none; d=google.com; s=arc-20160816; b=vptT740UbViJcNdKj2nZTOa6+cFxJoVMjvENuH+yPGysmTk1pvJRzbsz5aRxSdQ6kT F4xMD3siRCHWL248V4IYeLRoeiFEr6AJgRFR4PVD8Er/0LusQZudanf26tcYzN/uxFSA ic12mEvDlu6S1sFHT5Dk+lBKo/DQcRYZZPgyDNZXMEMfhQvTvPN/hFN9p0gz87sSPhfN NvMomdZGJcYD5Z+Znl/869V/uTMlU8zqq8+CDmEf3gLTR+rJWyLStaJiNKhaa25CKbgn JoAA+82QWDWxs2X5QRrYsp4VgGhRMv1SXlYzmPbA0zKeviuoH+sWjbk1TK9M/ci45oAx 1rdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=YT6bHQyIzp0hwhC+DXT8cjLU7+j3MkkVcaTYPOmtr2w=; b=xOB45BgbMxGgDyoUTs588cfseeh9CRH6vYWTSHgP/cdj65y4DTp3ur8j3hRS31wCW+ uRi/RlrMtjPrDeV3FqpuPUuorfVc2g/XOsV3qmDt2naz2odruR4TIGLyI+lhgLpwig7Y fHbpLEHISQHn4mZkTizezF+90+hOS6u5wSZKjnp4suJfIVUyyxbWRm5/RCxZC2cuXPwO TCL/46CPoIyJbrdcocVhnASFq21W53pIbkQdEIzMo2ow25U9h0GTIOZmQgDCZzchareN K4UiWPjr3bMELNUut4kXWSK5eIUlyz0OPwAhmiHCnvTRamb5ZaBz1VDIJA7FcT6lyWKc aTuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si22430835otn.150.2020.01.21.09.09.36; Tue, 21 Jan 2020 09:09:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729127AbgAURIP (ORCPT + 99 others); Tue, 21 Jan 2020 12:08:15 -0500 Received: from foss.arm.com ([217.140.110.172]:46072 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726714AbgAURIO (ORCPT ); Tue, 21 Jan 2020 12:08:14 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 03ACA30E; Tue, 21 Jan 2020 09:08:14 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7211A3F6C4; Tue, 21 Jan 2020 09:08:13 -0800 (PST) Date: Tue, 21 Jan 2020 17:08:11 +0000 From: Mark Brown To: "RAVULAPATI, VISHNU VARDHAN RAO" Cc: "Deucher, Alexander" , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "Mukunda, Vijendar" , Colin Ian King , YueHaibing , Kuninori Morimoto , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: Re: [PATCH] ASoC: amd: Fix for Subsequent Playback issue. Message-ID: <20200121170811.GJ4656@sirena.org.uk> References: <1579603421-24571-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> <20200121165925.GH4656@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k1BdFSKqAqVdu8k/" Content-Disposition: inline In-Reply-To: X-Cookie: You too can wear a nose mitten. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k1BdFSKqAqVdu8k/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 21, 2020 at 05:03:43PM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote: > > + kfree(rtd); > This free looks like a separate change which seems good and useful but > should be in a separate patch? > No Mark, > That is part of the fix. please let this be included in this patch. In what way is it part of the fix? This at least needs some sort of explanation somewhere, the changelog at least if not the code. --k1BdFSKqAqVdu8k/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4nL/oACgkQJNaLcl1U h9DmOwf/R4GKNHq0vWy03y4TCcrfj3Qty8T3/Tj3C/59WeAe9C1dbCHMrv0qrOg2 em7HOBX5PNR8V+SlAwiZUVLVADuyimVqYowdn+FhLpCFECEe7DsBXFdgMFADdq6C 4fFiY0LOi75NFjv+ERMTt5WVU8YSX7irTv/E8Xlb3iySeeYsFQCu71/DXIp4Rwlu JBqFQVspWAJhoZpcyNRkHssx81Tnw7ebGFk2KQWGAoEL1Q49vGsSHrcMFMF5vnWc pOlm70Vs+qR5oSYE3iR8FfY+NLwZDnO3yAmzPP1nhZ4S1iZYWLhQ4NYO/b/j7wCi 3skMtLFMJZImXBafHotySP/koVG/gw== =vEOZ -----END PGP SIGNATURE----- --k1BdFSKqAqVdu8k/--