Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161069AbWBAOxN (ORCPT ); Wed, 1 Feb 2006 09:53:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161068AbWBAOxM (ORCPT ); Wed, 1 Feb 2006 09:53:12 -0500 Received: from uproxy.gmail.com ([66.249.92.192]:10967 "EHLO uproxy.gmail.com") by vger.kernel.org with ESMTP id S1161067AbWBAOxM convert rfc822-to-8bit (ORCPT ); Wed, 1 Feb 2006 09:53:12 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=U8tZPLgQgH4bMwcn1RY2EUqw4BwBIupyHP39Tt0KJ+wkW7kOxFB1wMgvpLqJW44L4yFt1CwQM8oGxVV3pK9Ksz4PvJZRXCMpcKf9BABfYuBXtoDteG8ZfwWeXWTu6CaDshr52YkhBKBYVDdrPCGm70chASahASGIiU/XDsaktEQ= Message-ID: <58cb370e0602010653g3c60b2ffoa9a84f83c7af45c1@mail.gmail.com> Date: Wed, 1 Feb 2006 15:53:10 +0100 From: Bartlomiej Zolnierkiewicz To: Alan Cox Subject: Re: [patch] SGIIOC4 limit request size Cc: Jeremy Higdon , Jes Sorensen , Linus Torvalds , linux-kernel@vger.kernel.org In-Reply-To: <20060201133917.GA27011@devserv.devel.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <58cb370e0602010234p62521a00h6d8920c84cac44d5@mail.gmail.com> <20060201104913.GA152005@sgi.com> <58cb370e0602010308o4cde24aeg8d629b1b3d45cdd3@mail.gmail.com> <20060201111754.GB152005@sgi.com> <58cb370e0602010326k265ef278k4010df13fb5adf8c@mail.gmail.com> <20060201113607.GF152005@sgi.com> <20060201133917.GA27011@devserv.devel.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 781 Lines: 16 On 2/1/06, Alan Cox wrote: > On Wed, Feb 01, 2006 at 03:36:07AM -0800, Jeremy Higdon wrote: > > Here's one that removes xcount. It seems to work too. > > Should we set hwif->rqsize to 256, or are we pretty safe in > > expecting that the default won't rise? The driver should be > > 255 is the safest for LBA28 devices because a small number incorrectly > interpret 0 (meaning 256) as 0. And that can have unfortunate results We can blacklist vulnerable devices if needed. We have been using 256 for a long time now. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/