Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <4fbf026a-4878-cd65-55f7-7d992782b331@gmail.com> <20200116233939.GI27148@zn.tnic>
In-Reply-To: <20200116233939.GI27148@zn.tnic>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 21 Jan 2020 11:53:23 -0600
Message-ID: <CAL_JsqKqC_xm9rrHYaO87BtEv=-ji080p_G8axFduqu1mcqHCA@mail.gmail.com>
Subject: Re: [PATCH v9 1/2] dt-bindings: edac: arm-dmc520.txt
To:     Borislav Petkov <bp@alien8.de>
Cc:     Shiping Ji <shiping.linux@gmail.com>,
        James Morse <james.morse@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        linux-edac <linux-edac@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sasha Levin <sashal@kernel.org>, hangl@microsoft.com,
        Lei Wang <lewan@microsoft.com>, ruizhao@microsoft.com,
        shji@microsoft.com, Scott Branden <scott.branden@broadcom.com>,
        Yuqing Shen <yuqing.shen@broadcom.com>,
        Ray Jui <ray.jui@broadcom.com>, wangglei@gmail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 16, 2020 at 5:39 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Jan 15, 2020 at 06:32:27AM -0800, Shiping Ji wrote:
> > This is the device tree bindings for new EDAC driver dmc520_edac.c.
> >
> > Signed-off-by: Shiping Ji <shiping.linux@gmail.com>
> > Signed-off-by: Lei Wang <leiwang_git@outlook.com>
> > Reviewed-by: James Morse <james.morse@arm.com>
>
> So for this patch, v2 had Rui Zhao as an author:
>
> https://lkml.kernel.org/r/BN7PR08MB5572B3388B2D7DC8F6C7F285AE4C0@BN7PR08MB5572.namprd08.prod.outlook.com
>
> v3 got Lei as an author:
>
> https://lkml.kernel.org/r/CY1PR0401MB1244062C1738B09D6100F202860A0@CY1PR0401MB1244.namprd04.prod.outlook.com
>
> and now it is you.
>
> So when you send next time, think about who's going to be the author.
>
> > +     line numbers. The valid interrupt names are the followings:
>
> WARNING: 'followings' may be misspelled - perhaps 'following'?
> #51: FILE: Documentation/devicetree/bindings/edac/arm-dmc520.txt:10:
> +     line numbers. The valid interrupt names are the followings:
>
> Please integrate scripts/checkpatch.pl into your patch creation
> workflow. Some of the warnings/errors *actually* make sense.
>
> Also, this patch throws this other checkpatch warning:
>
> WARNING: DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst
>
> but since Rob reviewed it, I'm going to assume checkpatch is wrong here.

Would be happy for a schema, but not going to ask for that on a v9.

Rob