Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4164356ybl; Tue, 21 Jan 2020 14:13:45 -0800 (PST) X-Google-Smtp-Source: APXvYqwJXSHQHLtQhu9YtM3ZALazKI+6yAh+Wtou/BZfE1excn8z2YKMe6yg3CXDhu6T4BeDjwO3 X-Received: by 2002:a9d:23b5:: with SMTP id t50mr5055707otb.122.1579644824872; Tue, 21 Jan 2020 14:13:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579644824; cv=none; d=google.com; s=arc-20160816; b=va/3cFg0O9WjfYg9A8ZM0DAgAC3aOgsijCxkhji//XwhatvxG1k4OavUo5HRoCKqnn XGEDtxpRrWSZ0K9+3hkjqsc6/8ytJAcClLtklF17Mue4nYnyUFNcVCfjII9LPOelxyDK 14p7/TVBqKjIqjcEpdncid9FS7t0hb0u6lzw3TZCsV45NLxawCOXFSO64N0fpWjKKw3z y5cZQeTwtc4LY4B/97RiNL8UNxPtsU8QRtCQuYKO6gQDZQ2weKqxzenY1KnShqB63Sf4 z79jqdLQ8BNWReV2vK0WeH+F9kFqROfopjzs8u0R1FyLsKqGH121B/Fe2mzY3hfcqjt3 0zDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:date:subject:from:message-id; bh=Sqe9RcjdmacvEOtKWYUn4NuTZWHWA7itnAai5nvAbBs=; b=atDBue+4fJ0aCAQEuz9klvkH2gB0DiKPMiTcKYKBGlMuu4MJxmi0YjstTzMia9MlVI tjis47HAlEEMGV+Rl43RJGu8CDM4jR99oOb5NiuHH5uuqrMufXvqLI3neVLC2gaeXlXO ud3U42kztXlDeOao9UWUVhM7x9WF6JT7BXdz9K3WoKD2R2uqvFSYoFStntncR3yLcdzf Xc7N0HbtHKeEhay0eaSXAosmacD27tGuwpIRlXcBvFnHS1MJiWMvKfh7d7iMKIxkakSc LZjl1rFujpc+6mBHjFJmIyoQYYDhgQ2Tc/wvC9/LkxqUvVRtBOtQELx/PcNGj1d4PWum s5pQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k8si23900569otp.13.2020.01.21.14.13.33; Tue, 21 Jan 2020 14:13:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728981AbgAUWKg (ORCPT + 99 others); Tue, 21 Jan 2020 17:10:36 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:44722 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728139AbgAUWKg (ORCPT ); Tue, 21 Jan 2020 17:10:36 -0500 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id DDD5229980; Tue, 21 Jan 2020 17:10:35 -0500 (EST) Message-Id: From: Finn Thain Subject: [PATCH net v2 00/12] Fixes for SONIC ethernet driver Date: Wed, 22 Jan 2020 08:22:08 +1100 To: "David S. Miller" Cc: Thomas Bogendoerfer , Chris Zankel , Laurent Vivier , Geert Uytterhoeven , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Various SONIC driver problems have become apparent over the years, including tx watchdog timeouts, lost packets and duplicated packets. The problems are mostly caused by bugs in buffer handling, locking and (re-)initialization code. This patch series resolves these problems. This series has been tested on National Semiconductor hardware (macsonic), qemu-system-m68k (macsonic) and qemu-system-mips64el (jazzsonic). The emulated dp8393x device used in QEMU also has bugs. I have fixed the bugs that I know of in a series of patches at, https://github.com/fthain/qemu/commits/sonic --- Changed since v1: - Minor revisions as described in commit logs. - Deferred net-next patches. Finn Thain (12): net/sonic: Add mutual exclusion for accessing shared state net/sonic: Clear interrupt flags immediately net/sonic: Use MMIO accessors net/sonic: Fix interface error stats collection net/sonic: Fix receive buffer handling net/sonic: Avoid needless receive descriptor EOL flag updates net/sonic: Improve receive descriptor status flag check net/sonic: Fix receive buffer replenishment net/sonic: Quiesce SONIC before re-initializing descriptor memory net/sonic: Fix command register usage net/sonic: Fix CAM initialization net/sonic: Prevent tx watchdog timeout drivers/net/ethernet/natsemi/sonic.c | 380 ++++++++++++++++----------- drivers/net/ethernet/natsemi/sonic.h | 44 +++- 2 files changed, 262 insertions(+), 162 deletions(-) -- 2.24.1