Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 21 Jan 2020 17:10:18 -0800
From:   Yury Norov <yury.norov@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Alex Shi <alex.shi@linux.alibaba.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        William Breathitt Gray <vilhelm.gray@gmail.com>,
        "Tobin C. Harding" <tobin@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/bitmap: remove expect_eq_u32_array
Message-ID: <20200122011018.GA14737@yury-thinkpad>
References: <1579595625-250942-1-git-send-email-alex.shi@linux.alibaba.com>
 <20200121132050.GT32742@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200121132050.GT32742@smile.fi.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 21, 2020 at 03:20:50PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 21, 2020 at 04:33:45PM +0800, Alex Shi wrote:
> > expect_eq_u32_array isn't used from commit 3aa56885e516 ("bitmap:
> > replace bitmap_{from,to}_u32array").
> > And EXP2_IN_BITS are never used. so better to remove them.
> 
> I think better "fix" will be to add test cases.
> See the commit message in the
> 
> commit 3aa56885e51683a19c8aa71739fd279b3f501cd7
> Author: Yury Norov <ynorov@caviumnetworks.com>
> Date:   Tue Feb 6 15:38:06 2018 -0800
> 
>     bitmap: replace bitmap_{from,to}_u32array
> 
> -- 
> With Best Regards,
> Andy Shevchenko
 
On the other hand, it's almost 2 years gone since the commit you
mentioned, and nobody used the check_eq_u32_array(). So I think
it's long enough to consider the function useless.

This function is the last example of 2 lengths in input, so I'd
prefer to remove it. However, removing check_eq_u32_array() should
be synchronized with underlying __check_eq_u32_array().

Yury