Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4320533ybl; Tue, 21 Jan 2020 17:45:13 -0800 (PST) X-Google-Smtp-Source: APXvYqz5vZKFt5ocVOydMTJkJuRXoLUGqUqgfZX2ENAJfAm+HlAgj9N9Bz+vPK4BCgh1x9dUSIZq X-Received: by 2002:a05:6830:2102:: with SMTP id i2mr5672847otc.123.1579657513325; Tue, 21 Jan 2020 17:45:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579657513; cv=none; d=google.com; s=arc-20160816; b=rLAvlxXCNhdABMxforsEYW5wwzLu5f8tH3oanl0XLw/1qTg4ZJ11LWFj3QwPih1NMH V6RPuANGhC8vD1DNhjRUNi/o0Nyo8N5LloWBm7MY6k3fTt4D8uYbof/ZgpypRiJfrLUk htselP1vAJcdgljIQl2YEhydBLMqchK+/R2wqW+RvoVkWbcG3Yj/qnRo73YjAQU/NDsU HC/Kz9ssDufgXtDf2Ab5R1KXQBgLqw0C8pfPQPc+kXDID437m9XCSmR+2xFLLmb6qUFA MhQ098I61XHdn1P9l/2awrrmEI89NB59pVg+P4Kej9W+6XvInEmZ8kwc1drEKJgvRK/U TMYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :authenticated-by; bh=aEGQ2IluvAHozcOoiG7QkxzU0njfw54TZ/6rdqvrxJE=; b=fGb1em0BdykIAg6sL13A0zLDlKd73nxy9CKoJZ+hg8EAYjokWPjt2GCVddQC3/ULdT Jl8Pqc5OxzwBajYAEiZz02edA5tmAAF+ubwCuKpYR0gU0b3xyOXz6DqldbFzieAgI4xX irWm72t2MGnItZsyJhbKDtkECjC3HGIlOAqCHMIGzIMFPgXITxVOx3B158hCbgqTCjEv 27SJnOe8id7v5mjP+fqMxjGmPSXZj8YR56NtSEAJWh+4rvhklDaqFIOhgM9xFoxN6HKH uG+5n1k1QqlkXutZ0IEnbnPsKaXge9t83x+tXfEwpMR/tGSzDMso9jSuyLwPljEwRGUr ZF7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p22si21885335ota.43.2020.01.21.17.45.01; Tue, 21 Jan 2020 17:45:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729186AbgAVBn4 (ORCPT + 99 others); Tue, 21 Jan 2020 20:43:56 -0500 Received: from rtits2.realtek.com ([211.75.126.72]:56888 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728899AbgAVBnz (ORCPT ); Tue, 21 Jan 2020 20:43:55 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID 00M1hjvP020137, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (RTITCASV02.realtek.com.tw[172.21.6.19]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id 00M1hjvP020137 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 22 Jan 2020 09:43:47 +0800 Received: from fc30.localdomain (172.21.177.138) by RTITCASV02.realtek.com.tw (172.21.6.19) with Microsoft SMTP Server id 14.3.468.0; Wed, 22 Jan 2020 09:43:10 +0800 From: Hayes Wang To: CC: , , , , , Hayes Wang Subject: [PATCH net v2 6/9] r8152: disable test IO for RTL8153B Date: Wed, 22 Jan 2020 09:41:18 +0800 Message-ID: <1394712342-15778-354-Taiwan-albertk@realtek.com> X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <1394712342-15778-348-Taiwan-albertk@realtek.com> References: <1394712342-15778-338-Taiwan-albertk@realtek.com> <1394712342-15778-348-Taiwan-albertk@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.177.138] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For RTL8153B with QFN32, disable test IO. Otherwise, it may casue abnormal behavior for the device randomly. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 1fb85c79bd33..7efeddad1fc8 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -312,6 +312,7 @@ /* PLA_PHY_PWR */ #define TX_10M_IDLE_EN 0x0080 #define PFM_PWM_SWITCH 0x0040 +#define TEST_IO_OFF BIT(4) /* PLA_MAC_PWR_CTRL */ #define D3_CLK_GATED_EN 0x00004000 @@ -5538,6 +5539,15 @@ static void r8153b_init(struct r8152 *tp) ocp_data &= ~PLA_MCU_SPDWN_EN; ocp_write_word(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, ocp_data); + if (tp->version == RTL_VER_09) { + /* Disable Test IO for 32QFN */ + if (ocp_read_byte(tp, MCU_TYPE_PLA, 0xdc00) & BIT(5)) { + ocp_data = ocp_read_word(tp, MCU_TYPE_PLA, PLA_PHY_PWR); + ocp_data |= TEST_IO_OFF; + ocp_write_word(tp, MCU_TYPE_PLA, PLA_PHY_PWR, ocp_data); + } + } + set_bit(GREEN_ETHERNET, &tp->flags); /* rx aggregation */ -- 2.21.0