Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
References: <20200121151847.75223-1-andriy.shevchenko@linux.intel.com>
From:   Alex Shi <alex.shi@linux.alibaba.com>
Message-ID: <550c4e28-4826-dfef-9b8a-1d4290f52ff8@linux.alibaba.com>
Date:   Wed, 22 Jan 2020 10:06:15 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200121151847.75223-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=gbk
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


?? 2020/1/21 ????11:18, Andy Shevchenko д??:
> The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper")
> introduced some new test cases to the test_bitmap.c module. Among these
> it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.
> 
> Reported-by: Alex Shi <alex.shi@linux.alibaba.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  lib/test_bitmap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 61ed71c1daba..6b13150667f5 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -278,6 +278,8 @@ static void __init test_replace(void)
>  	unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
>  	DECLARE_BITMAP(bmap, 1024);
>  
> +	BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
> +
>  	bitmap_zero(bmap, 1024);
>  	bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
>  	expect_eq_bitmap(bmap, exp3_0_1, nbits);
> 

It looks nice. :)

Reviewed-by: Alex Shi <alex.shi@linux.alibaba.com>