Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 22 Jan 2020 13:19:24 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Alex Shi <alex.shi@linux.alibaba.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace/kprobe: remove MAX_KPROBE_CMDLINE_SIZE
Message-Id: <20200122131924.49b01587a8ed5149d44f3a94@kernel.org>
In-Reply-To: <20200121183438.635b0ff7@gandalf.local.home>
References: <1579586075-45132-1-git-send-email-alex.shi@linux.alibaba.com>
        <20200121183438.635b0ff7@gandalf.local.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 21 Jan 2020 18:34:38 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> Masami,
> 
> With your new bootconfig work, will you be utilizing
> MAX_KPROBE_CMDLINE_SIZE, or should it be removed?

Good catch! Yes, please remove it.
I think I have forgot to remove it when I switched
to COMMAND_LINE_SIZE while writing the code.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> 
> -- Steve
> 
> 
> On Tue, 21 Jan 2020 13:54:35 +0800
> Alex Shi <alex.shi@linux.alibaba.com> wrote:
> 
> > This limitation are never lunched from introduce commit 970988e19eb0
> > ("tracing/kprobe: Add kprobe_event= boot parameter")
> > 
> > Could we remove it if no intention to implement it?
> > 
> > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org> 
> > Cc: Ingo Molnar <mingo@redhat.com> 
> > Cc: linux-kernel@vger.kernel.org 
> > ---
> >  kernel/trace/trace_kprobe.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> > index 7f890262c8a3..eafa90d0f760 100644
> > --- a/kernel/trace/trace_kprobe.c
> > +++ b/kernel/trace/trace_kprobe.c
> > @@ -22,7 +22,6 @@
> >  
> >  #define KPROBE_EVENT_SYSTEM "kprobes"
> >  #define KRETPROBE_MAXACTIVE_MAX 4096
> > -#define MAX_KPROBE_CMDLINE_SIZE 1024
> >  
> >  /* Kprobe early definition from command line */
> >  static char kprobe_boot_events_buf[COMMAND_LINE_SIZE] __initdata;
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>