Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4454556ybl; Tue, 21 Jan 2020 21:15:35 -0800 (PST) X-Google-Smtp-Source: APXvYqwOwdPT4dT/QbySgVF0h31aNKlYjLb9H4Sj4tGUT+ARZCx5UxJDA3M7Hv/bTaboEMQhSBar X-Received: by 2002:a05:6808:8d0:: with SMTP id k16mr5776202oij.68.1579670135530; Tue, 21 Jan 2020 21:15:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579670135; cv=none; d=google.com; s=arc-20160816; b=VVttA4OW4t9J8kd4Ar/kQPpbdCnnmAWw+dbssZOGLKzL5xSeVGijY43eiE8PjObsih iQJ6eRu3GduUdDguAzvuDL8lw/cY3f/NvGzCKge8shUbg8U8zyy5aIY/o8Uk9zpYzgQw ANF8Cg8tj+4k8nwBcyY7HdqEEOaoweVLKb6NJERncEuFNpBOD8ogK/oC/7izfnmWxZ9u VCeukd5sJDaZYJZr3YLsbLC36R489jHWQ/6eeb3n1FzGOFimDwGE8BmLngtoUGuk0+h7 edOr4AbAMyOLUJY51UP2FhXXD1EIJOwaJD3G6h/AqQ0VjJVbDe8R5icG3sMd9RN4/bzT j6sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=G4zWcG38QbfOgSj2GyrGGnsjW0vqGvdhkVYZ4/Opd0A=; b=I7VT0l1Zhg5+0MYPGI1h1DBNmib+h6ltB4YEfKvnSrBAwNhuAE5kLDmrc+P8rC6GcX q8MgoQ2QS0ia7dSwlFSM/1hAOtl4syUwGAZFnd89Ha8JyE03GeSzkdxnFdes4xBsCAXl F/mk+pTp+AVw+YyzXNsFIafvVeukzN8Ii+QpoHiDzSeAFnKFTbY0c6r3yyM1gbmzCKVp eI2y+3XseO6tGUeK6pjbT0nxJ/KEeUdJR6ydmKAGIuKayEAlXs6tch898eGIgik3okis A7+arDt3Xo7NnCfTlvIf3U+nUW7km4GJCJhe9HWX2ZLqoAGaj9aROaY44wvf2Y4MqKOj 0nXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l8si20311143oii.249.2020.01.21.21.15.22; Tue, 21 Jan 2020 21:15:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725892AbgAVFNS (ORCPT + 99 others); Wed, 22 Jan 2020 00:13:18 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38806 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgAVFNS (ORCPT ); Wed, 22 Jan 2020 00:13:18 -0500 Received: by mail-pf1-f196.google.com with SMTP id x185so2741991pfc.5; Tue, 21 Jan 2020 21:13:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=G4zWcG38QbfOgSj2GyrGGnsjW0vqGvdhkVYZ4/Opd0A=; b=h3AI7ZF8s0P+PUkPIrdGfcWBiWdNrt06mkJ/vWASCjfSLCFH+rEMPeEUEIuF0kvI0i JI8771n0FEZQF9cecE5014UUEAUsVeaj0iUaCOqVZpCyJN8E0e3hCMxNKS5i3RevZZ3Q DDGMW7KRGv6GPpXNsfvPBfrkAQ0dOCXztpAISmoVERAiiZfYX6v+0AOmFWXvN8GHOyNH dO0rM37RtRzWaohOZjDjP/TDurfCY/2uR/vpjN4WZWm4qYO1ErMSIxdZ8mtZp/m3Guxl vD09z/dZcIqc/SAulxpkREzUUwhwsVb3q7/r/2ZREaLM5xX3fNK5Ydw3LDy2/Xr5Y7nB nirw== X-Gm-Message-State: APjAAAURQ7LjSkP1X7xtdAOieyH9PAstVNMCcekky5LZ5USXGjlPQ8GS W3l3Ijip7wnJi+n59RWaDyA0fYnP X-Received: by 2002:a63:1a1c:: with SMTP id a28mr9654899pga.374.1579669996726; Tue, 21 Jan 2020 21:13:16 -0800 (PST) Received: from ?IPv6:2601:647:4000:d7:1483:dec1:1c24:26ea? ([2601:647:4000:d7:1483:dec1:1c24:26ea]) by smtp.gmail.com with ESMTPSA id z4sm44777776pfn.42.2020.01.21.21.13.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 21:13:16 -0800 (PST) Subject: Re: [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from struct ufs_hba To: Bean Huo , alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200120130820.1737-1-huobean@gmail.com> <20200120130820.1737-7-huobean@gmail.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <6b6a7998-b6e3-6019-8588-18dbf622579a@acm.org> Date: Tue, 21 Jan 2020 21:13:14 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200120130820.1737-7-huobean@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-01-20 05:08, Bean Huo wrote: > Without variable is_init_prefetch, the current logic can guarantee > ufshcd_init_icc_levels() will execute only once, delete it now. How about changing this description into the following: A previous patch in this series introduced ufshcd_add_lus(). That function is called once per HBA which makes the is_init_prefetch member superfluous. Hence remove the is_init_prefetch member. Anyway: Reviewed-by: Bart Van Assche