Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 22 Jan 2020 09:51:46 +0300
From:   Cyrill Gorcunov <gorcunov@gmail.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Alex Shi <alex.shi@linux.alibaba.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
        Aubrey Li <aubrey.li@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/fpu: remove unused macros
Message-ID: <20200122065146.GI2437@uranus>
References: <1579596611-258536-1-git-send-email-alex.shi@linux.alibaba.com>
 <20200121114326.GF2437@uranus>
 <73a88e85-6995-6e3e-5eb8-a8c2b233364d@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <73a88e85-6995-6e3e-5eb8-a8c2b233364d@intel.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 21, 2020 at 03:07:23PM -0800, Dave Hansen wrote:
> FWIW, I'm not a massive fan of blindly removing stuff like this.  Maybe
> it's better to remove the cruft, but it's even better to try to figure
> out why I might have added them in the first place. :)
> 
> I *think* it was an attempt to ensure that a resulting PKRU value can be
> written to PKRU, independent of the type it was stored as.
> 
> Let me see if I can come up with something nicer than ripping these out.

Sure. Thanks a huge, Dave!