Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4565804ybl; Wed, 22 Jan 2020 00:04:51 -0800 (PST) X-Google-Smtp-Source: APXvYqwGiGG3btAe7WB58uw7mS1t5thIcxU0yc1nGWhN8YA8zwenQxHAAolTOfPObFAaQiZF8L46 X-Received: by 2002:a05:6830:154a:: with SMTP id l10mr6664475otp.44.1579680291334; Wed, 22 Jan 2020 00:04:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579680291; cv=none; d=google.com; s=arc-20160816; b=YdX7O75dhzT4hh0MVDAbiYZoU/PDIMciFRWCJAILUjTXLcehiRvtajEnizlwtLF/7e ZUX/YmWlGUwDHiPkWgpVJMx2pweHfikLpdnpFTfztTXVfDZHXDKsSRBismAEWbD12sZU MrxlwIF/D828wIH+WqjM0pYmIVT0IzZT1abwWtGTfEbL/KXG+ci4vypWdClDpd1jeZnT cC7TdWEh7K6SL1Z6onxYrmPIwMK8YG8Bs4w/DctvG7Ky1HpWUHUm/8NodDn54AuyjAdz YlDULwiadZw6k7Emvh8kg2Zc577Elc8ALBZr0or9w6d1zAWMh4FOd2hKSCjY/MhFoOao YnXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :authenticated-by; bh=tjLUfZ2aqPbEevYOZ6gH3Yd/+8fZ941Jh33rFKpPxTw=; b=PRv+M7a1uNeTxTrIZll71OZSVDK2jm+P4TnvHXR8GiV3yxOKRPToD8MJX6UAOMmw3/ hMpvVHLrwAZXjzJbYfq4fC0e7KQYr6tEzRZ6kzIPr8bGXRTRf1T6oPqTO6Xd3P3yvA1Z mnPwkmexRCI4kuUoC6Q/XhTsQGBREJSjZbQLqAQ/qernz9IqXU3R3Toy+cN5kK9oHrFn ukHHLGo79jJMGfh2IQfpQJIoUW95HUoFFQeJohxHK/NvqbTylx/KUn8d8ERgQ4S4UJnh ClwujClYQGmA3F2KoGVP4d/FC+SL1p05NkPp3LE9+kD35Y+IukYgs/Wif2iJ9dDhMxop Apug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14si24003356oti.33.2020.01.22.00.04.39; Wed, 22 Jan 2020 00:04:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729370AbgAVIDg (ORCPT + 99 others); Wed, 22 Jan 2020 03:03:36 -0500 Received: from rtits2.realtek.com ([211.75.126.72]:33438 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729190AbgAVIDe (ORCPT ); Wed, 22 Jan 2020 03:03:34 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID 00M83Umg009779, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (smtpsrv.realtek.com[172.21.6.99]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id 00M83Umg009779 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Jan 2020 16:03:30 +0800 Received: from RTEXMB06.realtek.com.tw (172.21.6.99) by RTEXMB06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Wed, 22 Jan 2020 16:03:29 +0800 Received: from RTITCASV01.realtek.com.tw (172.21.6.18) by RTEXMB06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.1779.2 via Frontend Transport; Wed, 22 Jan 2020 16:03:29 +0800 Received: from fc30.localdomain (172.21.177.138) by RTITCASV01.realtek.com.tw (172.21.6.18) with Microsoft SMTP Server id 14.3.468.0; Wed, 22 Jan 2020 16:03:27 +0800 From: Hayes Wang To: CC: , , , , , Hayes Wang Subject: [PATCH net v3 6/9] r8152: disable test IO for RTL8153B Date: Wed, 22 Jan 2020 16:02:10 +0800 Message-ID: <1394712342-15778-364-Taiwan-albertk@realtek.com> X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <1394712342-15778-358-Taiwan-albertk@realtek.com> References: <1394712342-15778-338-Taiwan-albertk@realtek.com> <1394712342-15778-358-Taiwan-albertk@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.177.138] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For RTL8153B with QFN32, disable test IO. Otherwise, it may cause abnormal behavior for the device randomly. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 1fb85c79bd33..7efeddad1fc8 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -312,6 +312,7 @@ /* PLA_PHY_PWR */ #define TX_10M_IDLE_EN 0x0080 #define PFM_PWM_SWITCH 0x0040 +#define TEST_IO_OFF BIT(4) /* PLA_MAC_PWR_CTRL */ #define D3_CLK_GATED_EN 0x00004000 @@ -5538,6 +5539,15 @@ static void r8153b_init(struct r8152 *tp) ocp_data &= ~PLA_MCU_SPDWN_EN; ocp_write_word(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, ocp_data); + if (tp->version == RTL_VER_09) { + /* Disable Test IO for 32QFN */ + if (ocp_read_byte(tp, MCU_TYPE_PLA, 0xdc00) & BIT(5)) { + ocp_data = ocp_read_word(tp, MCU_TYPE_PLA, PLA_PHY_PWR); + ocp_data |= TEST_IO_OFF; + ocp_write_word(tp, MCU_TYPE_PLA, PLA_PHY_PWR, ocp_data); + } + } + set_bit(GREEN_ETHERNET, &tp->flags); /* rx aggregation */ -- 2.21.0