Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ASoC: amd: Fix for Subsequent Playback issue.
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@amd.com>
Cc:     Alexander.Deucher@amd.com, broonie@kernel.org,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        YueHaibing <yuehaibing@huawei.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
References: <1579603421-24571-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
 <87d0bcmjob.wl-kuninori.morimoto.gx@renesas.com>
From:   vishnu <vravulap@amd.com>
Message-ID: <4a0d03a0-8cf8-8b55-0db2-4bbcb606454c@amd.com>
Date:   Wed, 22 Jan 2020 14:18:40 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
In-Reply-To: <87d0bcmjob.wl-kuninori.morimoto.gx@renesas.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fb91b55-e0ae-4d25-fa79-08d79f182cd3
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2020 08:50:48.0083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3JZKWE9/IRoMXJoduNU+I6qNUYJW1tfZIlFETLPmY3q0fhmsYTiLC8wFSLiEECv2VkZyE8jp7dWsplgISNUn3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3241
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 22/01/20 5:44 AM, Kuninori Morimoto wrote:
> 
> Hi Ravulapati
> 
>> If we play audio back to back, which kills one playback
>> and immediately start another, we can hear clicks.
>> This patch fixes the issue.
>>
>> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
>> ---
> (snip)
>> +	kfree(rtd);
> 
> Please double check soc_new_pcm_runtime() and
> soc_free_pcm_runtime() at soc-core.c.
> Because rtd is created via devm_kzalloc(),
> and has many related resources which need to be cared when rtd was freed.
> Just kfree() is not good/enough, I think.
> 
> I think you want to use is snd_soc_remove_pcm_runtime()
> instead of kfree()
> 
> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto
> 
I will create a separate patch for kfree and separate one for subsequent 
play back issue.