Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD
To:     Hongbo Yao <yaohongbo@huawei.com>, jens.wiklander@linaro.org
Cc:     chenzhou10@huawei.com, tee-dev@lists.linaro.org,
        linux-kernel@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "Rangasamy, Devaraj" <Devaraj.Rangasamy@amd.com>
References: <20200122071643.8122-1-yaohongbo@huawei.com>
From:   "Thomas, Rijo-john" <Rijo-john.Thomas@amd.com>
Message-ID: <422bf3dc-2d9c-1a12-a7d3-a6dc9349a648@amd.com>
Date:   Wed, 22 Jan 2020 14:34:19 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
In-Reply-To: <20200122071643.8122-1-yaohongbo@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b97f1b9-1dbb-4ce2-fbdc-08d79f1a1b4d
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2020 09:04:37.4925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 269jUdZK2JRz3ba2vhtEHBpyZH2+KRoNhUDM+DbLH6w3C8uOoPFlQEIceDEhIfDz9hz7H0YVvcPUIcJZCghOVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1239
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Deva, Herbert

Hi Hongbo,

On 22/01/20 12:46 pm, Hongbo Yao wrote:
> If CRYPTO_DEV_CCP_DD=m and AMDTEE=y, the following error is seen
> while building call.c or core.c
> 
> drivers/tee/amdtee/call.o: In function `handle_unload_ta':
> call.c:(.text+0x35f): undefined reference to `psp_tee_process_cmd'
> drivers/tee/amdtee/core.o: In function `amdtee_driver_init':
> core.c:(.init.text+0xf): undefined reference to `psp_check_tee_status
> 
> Fix the config dependency for AMDTEE here.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>

Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>

You may have to resubmit this patch to linux-crypto list, so that it shows
up in patchwork and applied to cryptodev-2.6 tree

Thanks,
Rijo

> ---
>  drivers/tee/amdtee/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tee/amdtee/Kconfig b/drivers/tee/amdtee/Kconfig
> index 4e32b6413b41..191f9715fa9a 100644
> --- a/drivers/tee/amdtee/Kconfig
> +++ b/drivers/tee/amdtee/Kconfig
> @@ -3,6 +3,6 @@
>  config AMDTEE
>  	tristate "AMD-TEE"
>  	default m
> -	depends on CRYPTO_DEV_SP_PSP
> +	depends on CRYPTO_DEV_SP_PSP && CRYPTO_DEV_CCP_DD
>  	help
>  	  This implements AMD's Trusted Execution Environment (TEE) driver.
>