Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4611770ybl; Wed, 22 Jan 2020 01:11:25 -0800 (PST) X-Google-Smtp-Source: APXvYqyKI55nldxQkCVeUwVo8W/Lp782gvhKUSKfp4iHJG5BB+3j6ZBJPq8XitsBtAZYaN0uxq/X X-Received: by 2002:a9d:4692:: with SMTP id z18mr6544309ote.163.1579684285699; Wed, 22 Jan 2020 01:11:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579684285; cv=none; d=google.com; s=arc-20160816; b=RvtLUn96q/7WrgOXix57SPraNkYV5QABNHhY9BeP91gayh8uamOGcQUuhDTOCwJ8IH WtV8HEFWnOVKkwYpK+3Ks7oiRPz9Vy2feTKCGe4C/TAyxVyYecPlv1QZx3eaciNtmSyN sDgIGemmwHR1OM4Aic3U5UDqsqCgnqjEYJbQ04i1jkDfjjaOQ1NoymT2CdbtluSpBcpl CAji2rLPQh8BgNN/DSD59Q+ZPBnt1RbXSVZ0f/jVvmsykbNbuc2FJzEUlz6XqyQ5rTCs OJP/q7QMR4LS70cOMYq4leObByvBEna5q0+48voEO2z/IabnjTCrU2GXCHKM5mO26enq pMKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=xrU+gwYstGQElAFBHhqNwT+9zkWE3UnbWobpn/MMSaU=; b=j2+9dPysnDonXRzomWHzK1NkIMcm2eZw+pNEP8nTtc9UnFLL4k4Jzp9+xpoXQR+Wxz ZDzb+rvp164DB/6sRn0Imb24VRyIgvuzXt8Db0B8N+UOJPlAT3dmvEBGMF3cH3UDES+0 182RZ0h1niW/pENkDmczxA9SbhcZnrqpth3yNx4qm1w3IonGxUkY8y1FC6mV3xsvYRPi AEDN8YjtPSR7OGZdsNRWkDFuPnSjJqI1ZnSMzs/Ncpo2E/OqJc9eHReus1fxVJJ4tQTM b6i0W+iJJGoWpKep2VzN2wfiddFPzOI8jkRbh5fMl53IqKFFrz6+H1aqNVsMOGZHuqMD ndWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si19731201oic.11.2020.01.22.01.11.13; Wed, 22 Jan 2020 01:11:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728609AbgAVJKT (ORCPT + 99 others); Wed, 22 Jan 2020 04:10:19 -0500 Received: from mga12.intel.com ([192.55.52.136]:54325 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgAVJKS (ORCPT ); Wed, 22 Jan 2020 04:10:18 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 01:10:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,349,1574150400"; d="scan'208";a="244990387" Received: from unknown (HELO bong5-HP-Z440.png.intel.com) ([10.221.118.166]) by orsmga002.jf.intel.com with ESMTP; 22 Jan 2020 01:10:14 -0800 From: Ong Boon Leong To: netdev@vger.kernel.org Cc: Tan Tee Min , Voon Weifeng , Giuseppe Cavallaro , Alexandre TORGUE , Jose Abreu , "David S . Miller" , Maxime Coquelin , Joao Pinto , Arnd Bergmann , Alexandru Ardelean , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v3 0/5] net: stmmac: general fixes for Ethernet functionality Date: Wed, 22 Jan 2020 17:09:31 +0800 Message-Id: <20200122090936.28555-1-boon.leong.ong@intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks to all feedbacks from community. We updated the patch-series to below:- 1/5: It ensures that the real_num_rx|tx_queues are set in both driver probe() and resume(). So, move the netif_set_real_num_rx|tx_queues() into stmmac_hw_setup(). Added lock_acquired to allow to decide when to rtnl_lock() & rtnl_unlock() pair:- stmmac_open(): rtnl_lock() & rtnl_unlock() is not needed. stmmac_resume(): rtnl_lock() & rtnl_unlock() is needed. 2/5: It ensures that the previous value of GMAC_VLAN_TAG register is read first before for updating the register. 3/5: It ensures the GMAC IP v4.xx and above behaves correctly to:- ip link set multicast off|on 4/5: Added similar IFF_MULTICAST flag for xgmac2. 5/5: It ensures PCI platform data is using plat->phy_interface. Rgds, Boon Leong Changes from v2:- patch 1/5 - added control for rtnl_lock() & rtnl_unlock() to ensure they are used forstmmac_resume() patch 4/5 - added IFF_MULTICAST flag check for xgmac to ensure multicast works correctly. v1:- - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid. Aashish Verma (1): net: stmmac: Fix incorrect location to set real_num_rx|tx_queues Tan, Tee Min (2): net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter Verma, Aashish (1): net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter Voon Weifeng (1): net: stmmac: update pci platform data to use phy_interface .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++---- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 19 ++++++++++++------- .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 4 files changed, 26 insertions(+), 18 deletions(-) -- 2.17.1