Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4612550ybl; Wed, 22 Jan 2020 01:12:34 -0800 (PST) X-Google-Smtp-Source: APXvYqzDttrdkPRH9sLI5JRaMQkNGoqmsgAFOdIEoqVzSqbykpp+JyGKp+znwqs567dz6g7K0F6p X-Received: by 2002:aca:d6c8:: with SMTP id n191mr6341948oig.103.1579684353983; Wed, 22 Jan 2020 01:12:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579684353; cv=none; d=google.com; s=arc-20160816; b=br3c8gp//M86q5nU6hHX5bUEzYiRptQzF56hWgJ69MsT43qMthcTM5IXw6mY8mCT4K E37nVveUlDi/b10kA0K6r2taMAgaTxuTtUX8/fzYpyHMreV/fapbr6K/b10eRw1jt66s Njcd7pwDEhc9Dx+nE268YMGbYX0M8iWglSE1mSGbd33PHet3PqmdhNROA6rfOf2J2sUn xPeIu5AoPR0eWnEnHT6n63EJCsxAdX0I+3mf0rIHMa8LkI5iUMYYKMy55JdbWYwshUE/ cTAmCOMArUpHsDiQd3qxig5V1ZNks8umUFXYaDU3FzuYFHs+PxxOlVZgnHOLd65J/iGe 7Wcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=nHWvmE03JZRYo6r4EAMQLc+dpQblzQVX9abWDEhKIdU=; b=ija6ATXhSC26dGwjF/o3CvxHK72xhU+5mmCBX1upd3cLm5bgDY4bzVhjNTXZjK1QNK B7TZNxryHYOG4PH06KnnBD1baT8K41tNNcO3DrSUpB8hcwdWqZ1uFVBP+Yo7ACa+DUS9 GMl/HryQKWpeEti1qZvJTUF+E/dJJ0oMJbXZz2ESXX9VSb7s3lgN8+Tm2Dee6kYPpJM5 Be4emXPCgMHHdftgA0j0vaLjpzlLBef/OxDjHIJd6qTN4U3jCPWHx7Y314Zpjs0MtMCz ABJtq2Fjz/M3N8n4bqzNhLWy0+3K0ctt2WoHt+0VbIOkik23SbLbvobFk/jMmR5Sa/sp N+cQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d140si21647693oig.269.2020.01.22.01.12.22; Wed, 22 Jan 2020 01:12:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729151AbgAVJKm (ORCPT + 99 others); Wed, 22 Jan 2020 04:10:42 -0500 Received: from mga12.intel.com ([192.55.52.136]:54325 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729093AbgAVJKh (ORCPT ); Wed, 22 Jan 2020 04:10:37 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 01:10:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,349,1574150400"; d="scan'208";a="244990551" Received: from unknown (HELO bong5-HP-Z440.png.intel.com) ([10.221.118.166]) by orsmga002.jf.intel.com with ESMTP; 22 Jan 2020 01:10:33 -0800 From: Ong Boon Leong To: netdev@vger.kernel.org Cc: Tan Tee Min , Voon Weifeng , Giuseppe Cavallaro , Alexandre TORGUE , Jose Abreu , "David S . Miller" , Maxime Coquelin , Joao Pinto , Arnd Bergmann , Alexandru Ardelean , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net v3 5/5] net: stmmac: update pci platform data to use phy_interface Date: Wed, 22 Jan 2020 17:09:36 +0800 Message-Id: <20200122090936.28555-6-boon.leong.ong@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200122090936.28555-1-boon.leong.ong@intel.com> References: <20200122090936.28555-1-boon.leong.ong@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Voon Weifeng The recent patch to support passive mode converter did not take care the phy interface configuration in PCI platform data. Hence, converting all the PCI platform data from plat->interface to plat->phy_interface as the default mode is meant for PHY. Fixes: 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt") Signed-off-by: Voon Weifeng Tested-by: Tan, Tee Min Signed-off-by: Ong Boon Leong --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c index 8237dbc3e991..d2bc04dedd7c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c @@ -96,7 +96,7 @@ static int stmmac_default_data(struct pci_dev *pdev, plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_GMII; + plat->phy_interface = PHY_INTERFACE_MODE_GMII; plat->dma_cfg->pbl = 32; plat->dma_cfg->pblx8 = true; @@ -220,7 +220,8 @@ static int ehl_sgmii_data(struct pci_dev *pdev, { plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_SGMII; + plat->phy_interface = PHY_INTERFACE_MODE_SGMII; + return ehl_common_data(pdev, plat); } @@ -233,7 +234,8 @@ static int ehl_rgmii_data(struct pci_dev *pdev, { plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_RGMII; + plat->phy_interface = PHY_INTERFACE_MODE_RGMII; + return ehl_common_data(pdev, plat); } @@ -261,7 +263,7 @@ static int tgl_sgmii_data(struct pci_dev *pdev, { plat->bus_id = 1; plat->phy_addr = 0; - plat->interface = PHY_INTERFACE_MODE_SGMII; + plat->phy_interface = PHY_INTERFACE_MODE_SGMII; return tgl_common_data(pdev, plat); } @@ -361,7 +363,7 @@ static int quark_default_data(struct pci_dev *pdev, plat->bus_id = pci_dev_id(pdev); plat->phy_addr = ret; - plat->interface = PHY_INTERFACE_MODE_RMII; + plat->phy_interface = PHY_INTERFACE_MODE_RMII; plat->dma_cfg->pbl = 16; plat->dma_cfg->pblx8 = true; @@ -418,7 +420,7 @@ static int snps_gmac5_default_data(struct pci_dev *pdev, plat->bus_id = 1; plat->phy_addr = -1; - plat->interface = PHY_INTERFACE_MODE_GMII; + plat->phy_interface = PHY_INTERFACE_MODE_GMII; plat->dma_cfg->pbl = 32; plat->dma_cfg->pblx8 = true; -- 2.17.1