Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4627801ybl; Wed, 22 Jan 2020 01:33:44 -0800 (PST) X-Google-Smtp-Source: APXvYqxgIyPKPGMBZOv9Rvf1qQd2MQVXClsgcM3IzUg/4oBx3EZYHiq1cmXHfpSx41PvyUhctuco X-Received: by 2002:a9d:51c1:: with SMTP id d1mr6431117oth.136.1579685624451; Wed, 22 Jan 2020 01:33:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579685624; cv=none; d=google.com; s=arc-20160816; b=qhg2z9dJutl2KHVIeTJh6y5rBJbYQRcYpSQhS/DUwk6RL1+jU4O0eVax3530JgI8em av+ZiifTwe/XUMjno1sGwVavjLlUKbw07YYWdXEHUeAwXVwNpeu0hGqXQKyPlYApiabV wg02M6GVklD3GtG4Qk40+sbO+So9nSjGborMSb0yCjB2yCdZwteXqtghNLzpvWI0slBW qKnL5iy6uP2nQmRHbt+B86UDD2pOL31qSam7A+GLEO5csu/inUmOXzCoLqxfsxQXRf+4 mZ2polJAKIo0hx3/tTQj8p47QP9XuOWxwxZ00mRCSCkeZkDlV1kRKRUR1nwIjF3e5nMM 42bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Eaz1I/3hTlAs2zx1d9p0VBWe9Vi36g/AVwvtoq5udmk=; b=YrHfzus24KvGO8DlbLp2NmoEFQv7HlqL4maF+BHJNhlxrDl7ovi5GbslGxyVfqDQWU ajUXYO+0JvDEDGxvvdjq8jdKvKl5U/I7U1lYDFYW3ePOfJLg8dBq5D0pSTt73ZR5kV2V SFAmVqpmW82auYR2ItZAkH8TOM/RF4gc+n4pUDzVbRIZQT7bimFNox13ofjjSC4pd4sQ Dg7+Vn3gLW68XrJ3JHUgRazXXSlFvwIkNcjyaJm4UoiGfpLezgWDMIjpNWKpcQearQ7y pRqiAZSHh8/nju2nRVbaZaMCjxeeBBKPQ5J3HiIMHjFjGww8QOnS6cA1jANJzUUJyZos hQ3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p7si5bRl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r10si21450794otn.241.2020.01.22.01.33.32; Wed, 22 Jan 2020 01:33:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p7si5bRl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729668AbgAVJbX (ORCPT + 99 others); Wed, 22 Jan 2020 04:31:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:43344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729637AbgAVJbV (ORCPT ); Wed, 22 Jan 2020 04:31:21 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A36724672; Wed, 22 Jan 2020 09:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579685481; bh=0wWvWshp+tvgSFI8pOHOJrx1Z8wnPY0sv8HdFJhYBDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p7si5bRl7mz1nWde0buWQb4KAnPXsYhbKJ+EmW4+ghOomVMSZ9DWJeO9DcNyOZ3py NmdqQBZE1A0cfYs4JEG2hx0qtpzbVbtsyLmsT2B8+/nHRNi+F6HmkBX+rThixuZT4l 7jgK4XLvt1J5IKKQ7DuHZ1ZOi0C09ahLbFOoO23E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sanjay Konduri , Sushant Kumar Mishra , Kalle Valo , Ben Hutchings Subject: [PATCH 4.4 04/76] rsi: add fix for crash during assertions Date: Wed, 22 Jan 2020 10:28:20 +0100 Message-Id: <20200122092752.135518029@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200122092751.587775548@linuxfoundation.org> References: <20200122092751.587775548@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sanjay Konduri commit abd39c6ded9db53aa44c2540092bdd5fb6590fa8 upstream. Observed crash in some scenarios when assertion has occurred, this is because hw structure is freed and is tried to get accessed in some functions where null check is already present. So, avoided the crash by making the hw to NULL after freeing. Signed-off-by: Sanjay Konduri Signed-off-by: Sushant Kumar Mishra Signed-off-by: Kalle Valo Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c @@ -199,6 +199,7 @@ void rsi_mac80211_detach(struct rsi_hw * ieee80211_stop_queues(hw); ieee80211_unregister_hw(hw); ieee80211_free_hw(hw); + adapter->hw = NULL; } rsi_remove_dbgfs(adapter);