Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4632570ybl; Wed, 22 Jan 2020 01:40:03 -0800 (PST) X-Google-Smtp-Source: APXvYqytMNjF3PegWRlZvFK10h5DX2n9QnMtzemr6BhRvUYlwerJiyC8Ms8fFRpgosVTj05isbj+ X-Received: by 2002:a9d:65da:: with SMTP id z26mr6627251oth.197.1579686003419; Wed, 22 Jan 2020 01:40:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579686003; cv=none; d=google.com; s=arc-20160816; b=KvNz0RhyA8mNqv7e/0wZi6ABYHxGe3iEZVzCdQz+gqXfGGoYnWT7lHDNi9Yge8Vi/W COPnoRo8bkveNPcvPKA1UJS79U8IfGCOnC67Og1cm3GJ09AZKydobsltk3IvJ6QbLeQl xR9VmH4gMZnYSrdMgH4nRPsar91ZeHJZKTou6am6xuFuCm4w3fZaLxYOSgxMPPggW0vB yWfrp111XhOj2zyNVABzrjAr15ObQz40O3Sz/jL0YiJyy5sN9q5Drte40QkfAOoVIs+d ZXWvUkOTqyCUOSUl5N9QB2qIplTVlgnXVwVzoDoaIxLH11qrpZBy9pIS4dFBLUGdYIkl YSug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VVgLqn8F7HJxRbkintSjv2S2/wLr5kyA93CGCZgRBjc=; b=CrJuaf/xZ5DBEfE7xFmWs40qXvSBFvwqGZ+LYjfG5CyZtns/pC+Kg2poZhAj2Tie0k 1ITN4CPnGYceLeZ0bjbLPPymygOKzK+dgBoba0CiIUFDE2h4BsO4amD0epbI3YSfu834 XVyv+DOpWWEXphcU5APOQp/UgvbmcQIyauVWpSASfmBIDDqW4mBBpaDyYS2xZLY2U6sx HHZ03yp8L3hKnEOCc7lC3wftJYJIPPQgVLpxlsTl27gCt4I3AjuAsf/ZfazA/LENS5Hp oxL/ZtJO9xil4pXYK0kv5dxTzo3q+NSOb8rsaU4Y8RxFKJxC4WOt8EbSUC7T28V9bY9I rVMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=daGdDfHH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4si20464413oib.70.2020.01.22.01.39.38; Wed, 22 Jan 2020 01:40:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=daGdDfHH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731657AbgAVJhV (ORCPT + 99 others); Wed, 22 Jan 2020 04:37:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:53284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729863AbgAVJhR (ORCPT ); Wed, 22 Jan 2020 04:37:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73DB824684; Wed, 22 Jan 2020 09:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579685835; bh=qXgDHxOXuDZD5R4tdepu4dG3IdI8o0vQJkklPvnJ3Aw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=daGdDfHHrmX1cIcM2BZ7OslPpHkLXMRAEERh+9dX+knw1/76qdCw9uiSpCmhEHnzM XI865hZAFFc9n1dfDKXd/FaP0WHVnbqqYKe1x42RmhgoueFLufP6k8CiIB9wHS33Pr V3Ao0doYtIbiU7I/fgglqxntlGzTlqef1NbMLuDQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Manish Rangankar , "Martin K. Petersen" Subject: [PATCH 4.9 92/97] scsi: qla4xxx: fix double free bug Date: Wed, 22 Jan 2020 10:29:36 +0100 Message-Id: <20200122092810.904922779@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200122092755.678349497@linuxfoundation.org> References: <20200122092755.678349497@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian commit 3fe3d2428b62822b7b030577cd612790bdd8c941 upstream. The variable init_fw_cb is released twice, resulting in a double free bug. The call to the function dma_free_coherent() before goto is removed to get rid of potential double free. Fixes: 2a49a78ed3c8 ("[SCSI] qla4xxx: added IPv6 support.") Link: https://lore.kernel.org/r/1572945927-27796-1-git-send-email-bianpan2016@163.com Signed-off-by: Pan Bian Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla4xxx/ql4_mbx.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++ b/drivers/scsi/qla4xxx/ql4_mbx.c @@ -641,9 +641,6 @@ int qla4xxx_initialize_fw_cb(struct scsi if (qla4xxx_get_ifcb(ha, &mbox_cmd[0], &mbox_sts[0], init_fw_cb_dma) != QLA_SUCCESS) { - dma_free_coherent(&ha->pdev->dev, - sizeof(struct addr_ctrl_blk), - init_fw_cb, init_fw_cb_dma); goto exit_init_fw_cb; }