Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030394AbWBASCn (ORCPT ); Wed, 1 Feb 2006 13:02:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932463AbWBASCn (ORCPT ); Wed, 1 Feb 2006 13:02:43 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:38827 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932448AbWBASCm (ORCPT ); Wed, 1 Feb 2006 13:02:42 -0500 Date: Wed, 1 Feb 2006 18:02:37 +0000 From: Christoph Hellwig To: "Chen, Kenneth W" Cc: "'Akinobu Mita'" , Grant Grundler , Linux Kernel Development , linux-ia64@vger.kernel.org Subject: Re: [PATCH 1/12] generic *_bit() Message-ID: <20060201180237.GA18464@infradead.org> Mail-Followup-To: Christoph Hellwig , "Chen, Kenneth W" , 'Akinobu Mita' , Grant Grundler , Linux Kernel Development , linux-ia64@vger.kernel.org References: <20060126032918.GB9984@miraclelinux.com> <200602011511.k11FBgg00314@unix-os.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200602011511.k11FBgg00314@unix-os.sc.intel.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 21 On Wed, Feb 01, 2006 at 07:11:34AM -0800, Chen, Kenneth W wrote: > Akinobu Mita wrote on Wednesday, January 25, 2006 7:29 PM > > This patch introduces the C-language equivalents of the functions below: > > > > - atomic operation: > > void set_bit(int nr, volatile unsigned long *addr); > > void clear_bit(int nr, volatile unsigned long *addr); > > void change_bit(int nr, volatile unsigned long *addr); > > int test_and_set_bit(int nr, volatile unsigned long *addr); > > int test_and_clear_bit(int nr, volatile unsigned long *addr); > > int test_and_change_bit(int nr, volatile unsigned long *addr); > > I wonder why you did not make these functions take volatile > unsigned int * address argument? Because they are defined to operate on arrays of unsigned long - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/