Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
CC:     <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: rt5659: add S32_LE format
From:   Sameer Pujar <spujar@nvidia.com>
To:     <oder_chiou@realtek.com>, <tiwai@suse.com>, <perex@perex.cz>
References: <1579501059-27936-1-git-send-email-spujar@nvidia.com>
 <74a42452-f19c-1175-9928-da12ccad621d@nvidia.com>
Message-ID: <c700f22c-a053-7f39-dddf-41abe52cad77@nvidia.com>
Date:   Wed, 22 Jan 2020 15:57:14 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <74a42452-f19c-1175-9928-da12ccad621d@nvidia.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Reviewers,

Kindly review. Thanks.

On 1/20/2020 11:54 AM, Sameer Pujar wrote:
> Removing Bard(bardliao@realtek.com) from "to" list since I am getting=20
> undelivered message.
>
> Oder,
> Please add right folks as you feel necessary. Thanks.
>
> On 1/20/2020 11:47 AM, Sameer Pujar wrote:
>> ALC5659 supports maximum data length of 24-bit. Currently driver=20
>> supports
>> S24_LE which is a 32-bit container with valid data in [23:0] and 0s=20
>> in MSB.
>> S24_3LE is not commonly used and is hard to find audio streams with this
>> format. Also many SoC HW do not support S24_LE and S32_LE is used in
>> general. The 24-bit data can be represented in S32_LE [31:8] and 0s are
>> padded in LSB.
>>
>> This patch adds S32_LE to ALC5659 driver and data length for this is set
>> to 24 as per codec's maximum data length support. This helps to play
>> 24-bit audio, packed in S32_LE, on HW which do not support S24_LE.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> =C2=A0 sound/soc/codecs/rt5659.c | 4 +++-
>> =C2=A0 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c
>> index fc74dd63..f910ddf 100644
>> --- a/sound/soc/codecs/rt5659.c
>> +++ b/sound/soc/codecs/rt5659.c
>> @@ -3339,6 +3339,7 @@ static int rt5659_hw_params(struct=20
>> snd_pcm_substream *substream,
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 val_len |=3D RT56=
59_I2S_DL_20;
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break;
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case 24:
>> +=C2=A0=C2=A0=C2=A0 case 32:
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 val_len |=3D RT56=
59_I2S_DL_24;
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break;
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case 8:
>> @@ -3733,7 +3734,8 @@ static int rt5659_resume(struct=20
>> snd_soc_component *component)
>> =C2=A0 =C2=A0 #define RT5659_STEREO_RATES SNDRV_PCM_RATE_8000_192000
>> =C2=A0 #define RT5659_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |=20
>> SNDRV_PCM_FMTBIT_S20_3LE | \
>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 SNDRV_PCM_FMTBIT_S24_LE | SN=
DRV_PCM_FMTBIT_S8)
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 SNDRV_PCM_FMTBIT_S24_LE | SN=
DRV_PCM_FMTBIT_S32_LE | \
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 SNDRV_PCM_FMTBIT_S8)
>> =C2=A0 =C2=A0 static const struct snd_soc_dai_ops rt5659_aif_dai_ops =3D=
 {
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .hw_params =3D rt5659_hw_params,