Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4745568ybl; Wed, 22 Jan 2020 04:01:08 -0800 (PST) X-Google-Smtp-Source: APXvYqx/ka6Yt40BoK+dWUon51HEB8Oy9+R6hVvgXzZGPIlwbDkR0PTlNG6dlvY1ZaZpPm+vg7hA X-Received: by 2002:a9d:198b:: with SMTP id k11mr7364249otk.295.1579694467602; Wed, 22 Jan 2020 04:01:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579694467; cv=none; d=google.com; s=arc-20160816; b=pOuV6rmLbsn0zbfN2savqZJ4jB3/+lwDCLTtJ1HI6Wwptk64GNAIPFdNtEdMhJWDe2 a+F+jEfb4EZrHi2kgEYdWe//CtZXcbbP7edZ1RPCRLq/oGej1sSI+3HGso6IOyp/qjg5 cZ2RaXSY3X7h2woKH4/7s7x+mRb+sf7ZGbtzFvUE9GQNmXtUsQIKZa5EglSm6ZbE9rFJ UF8sFx7XOCZ0Wgp1CQzhWC74UkGgE9kDZ0LwJF+BY07pOqV1cwCnDQPWuKuOiLOs/uBe PTUHi3dVDJNxB3z9hUotJSinKyWUH9sr63NnmYtQ+apnulEA8o6Kgy/pHrI/fQ/KrpRH K3uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:reply-to; bh=QS4TIj55HNmblTQ1tWnmv9IsfKHy0puHFb3BZB6h8tk=; b=JjlWHFhxVfnRIyfOaWQr51LXp/OizHljJGZ/7e/e6zrdhoMIa4B8sndQrCoOk2sq2G hn+xj8SlVOSXMWYKox7TXY6GVqcC9hd0qmpONcdxe6R4vtoshqMr7dfIER8FZZHfmE5O jkqHt5px8XCPS5Kfnqc1th8ZMxUlgJLeVJ3cU1SZ05Ea0QttbMFxL70tit2yHK/CghRl 1rJwyySCkh6HOs0JID3PJh64TZPpjAnLUsRY/bDt9bhlt7YD9aHSU6J9APx0SqLbRdOA yjryUa4kbCvdjC8gLOGxNpMCErHqpRYEwFNPvns+XI9PKdmBTDTMS82USVgcwrIXUuaS EYgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si23932191otq.137.2020.01.22.04.00.55; Wed, 22 Jan 2020 04:01:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729195AbgAVL6t (ORCPT + 99 others); Wed, 22 Jan 2020 06:58:49 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:44544 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbgAVL6s (ORCPT ); Wed, 22 Jan 2020 06:58:48 -0500 Received: by mail-lj1-f195.google.com with SMTP id q8so6436482ljj.11 for ; Wed, 22 Jan 2020 03:58:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=QS4TIj55HNmblTQ1tWnmv9IsfKHy0puHFb3BZB6h8tk=; b=EkcpwKGz8xZiAEDVO+3UvGtXj3epxrDgSn55U2hQeVgTtrHnrvYdLbyuGLud/QgP6l ZAhe9+2oXDwA697jS3+GKpjwN8awxj5w6CPEnHiqIBjWx7Qppl3oJPRmFPAM1TFqspfr QEs/uFcgzCf6cEgV9L/WR7aw2L3FhCiqbMVoCcesaud1tVSauSR+opzoXymsGc4vjkI5 hd+/huZGE6l3p3uJDgG3ruBKyzdyjZO6GnbmmhRhmBUbGJH+RbDxSCysjFdR0gF62tcC kaguzc3yNVnqIf7uhPVonrUMIIFlAn2lkNXLKlTWC+KmHRtLqcvJX2iVdaopMMdfY1YR U3ZQ== X-Gm-Message-State: APjAAAUHaarbpPiK1FBWon0X4qzlI/SL1aZs9E0hr0K6fOHCktwbCLCM Y8sZPqzw5x7DQA8Uunh68mYwv2h0208= X-Received: by 2002:a2e:9196:: with SMTP id f22mr20262602ljg.18.1579694326810; Wed, 22 Jan 2020 03:58:46 -0800 (PST) Received: from [192.168.42.103] ([213.87.155.128]) by smtp.gmail.com with ESMTPSA id h7sm20913623lfj.29.2020.01.22.03.58.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2020 03:58:45 -0800 (PST) Reply-To: alex.popov@linux.com Subject: Re: [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose To: Kees Cook , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: notify@kernel.org References: <20200102234907.585508-1-alex.popov@linux.com> From: Alexander Popov Autocrypt: addr=alex.popov@linux.com; prefer-encrypt=mutual; keydata= mQINBFX15q4BEADZartsIW3sQ9R+9TOuCFRIW+RDCoBWNHhqDLu+Tzf2mZevVSF0D5AMJW4f UB1QigxOuGIeSngfmgLspdYe2Kl8+P8qyfrnBcS4hLFyLGjaP7UVGtpUl7CUxz2Hct3yhsPz ID/rnCSd0Q+3thrJTq44b2kIKqM1swt/F2Er5Bl0B4o5WKx4J9k6Dz7bAMjKD8pHZJnScoP4 dzKPhrytN/iWM01eRZRc1TcIdVsRZC3hcVE6OtFoamaYmePDwWTRhmDtWYngbRDVGe3Tl8bT 7BYN7gv7Ikt7Nq2T2TOfXEQqr9CtidxBNsqFEaajbFvpLDpUPw692+4lUbQ7FL0B1WYLvWkG cVysClEyX3VBSMzIG5eTF0Dng9RqItUxpbD317ihKqYL95jk6eK6XyI8wVOCEa1V3MhtvzUo WGZVkwm9eMVZ05GbhzmT7KHBEBbCkihS+TpVxOgzvuV+heCEaaxIDWY/k8u4tgbrVVk+tIVG 99v1//kNLqd5KuwY1Y2/h2MhRrfxqGz+l/f/qghKh+1iptm6McN//1nNaIbzXQ2Ej34jeWDa xAN1C1OANOyV7mYuYPNDl5c9QrbcNGg3D6gOeGeGiMn11NjbjHae3ipH8MkX7/k8pH5q4Lhh Ra0vtJspeg77CS4b7+WC5jlK3UAKoUja3kGgkCrnfNkvKjrkEwARAQABtCZBbGV4YW5kZXIg UG9wb3YgPGFsZXgucG9wb3ZAbGludXguY29tPokCVwQTAQgAQQIbIwIeAQIXgAULCQgHAwUV CgkICwUWAgMBAAIZARYhBLl2JLAkAVM0bVvWTo4Oneu8fo+qBQJdehKcBQkLRpLuAAoJEI4O neu8fo+qrkgP/jS0EhDnWhIFBnWaUKYWeiwR69DPwCs/lNezOu63vg30O9BViEkWsWwXQA+c SVVTz5f9eB9K2me7G06A3U5AblOJKdoZeNX5GWMdrrGNLVISsa0geXNT95TRnFqE1HOZJiHT NFyw2nv+qQBUHBAKPlk3eL4/Yev/P8w990Aiiv6/RN3IoxqTfSu2tBKdQqdxTjEJ7KLBlQBm 5oMpm/P2Y/gtBiXRvBd7xgv7Y3nShPUDymjBnc+efHFqARw84VQPIG4nqVhIei8gSWps49DX kp6v4wUzUAqFo+eh/ErWmyBNETuufpxZnAljtnKpwmpFCcq9yfcMlyOO9/viKn14grabE7qE 4j3/E60wraHu8uiXJlfXmt0vG16vXb8g5a25Ck09UKkXRGkNTylXsAmRbrBrA3Moqf8QzIk9 p+aVu/vFUs4ywQrFNvn7Qwt2hWctastQJcH3jrrLk7oGLvue5KOThip0SNicnOxVhCqstjYx KEnzZxtna5+rYRg22Zbfg0sCAAEGOWFXjqg3hw400oRxTW7IhiE34Kz1wHQqNif0i5Eor+TS 22r9iF4jUSnk1jaVeRKOXY89KxzxWhnA06m8IvW1VySHoY1ZG6xEZLmbp3OuuFCbleaW07OU 9L8L1Gh1rkAz0Fc9eOR8a2HLVFnemmgAYTJqBks/sB/DD0SuuQINBFX15q4BEACtxRV/pF1P XiGSbTNPlM9z/cElzo/ICCFX+IKg+byRvOMoEgrzQ28ah0N5RXQydBtfjSOMV1IjSb3oc23z oW2J9DefC5b8G1Lx2Tz6VqRFXC5OAxuElaZeoowV1VEJuN3Ittlal0+KnRYY0PqnmLzTXGA9 GYjw/p7l7iME7gLHVOggXIk7MP+O+1tSEf23n+dopQZrkEP2BKSC6ihdU4W8928pApxrX1Lt tv2HOPJKHrcfiqVuFSsb/skaFf4uveAPC4AausUhXQVpXIg8ZnxTZ+MsqlwELv+Vkm/SNEWl n0KMd58gvG3s0bE8H2GTaIO3a0TqNKUY16WgNglRUi0WYb7+CLNrYqteYMQUqX7+bB+NEj/4 8dHw+xxaIHtLXOGxW6zcPGFszaYArjGaYfiTTA1+AKWHRKvD3MJTYIonphy5EuL9EACLKjEF v3CdK5BLkqTGhPfYtE3B/Ix3CUS1Aala0L+8EjXdclVpvHQ5qXHs229EJxfUVf2ucpWNIUdf lgnjyF4B3R3BFWbM4Yv8QbLBvVv1Dc4hZ70QUXy2ZZX8keza2EzPj3apMcDmmbklSwdC5kYG EFT4ap06R2QW+6Nw27jDtbK4QhMEUCHmoOIaS9j0VTU4fR9ZCpVT/ksc2LPMhg3YqNTrnb1v RVNUZvh78zQeCXC2VamSl9DMcwARAQABiQI8BBgBCAAmAhsMFiEEuXYksCQBUzRtW9ZOjg6d 67x+j6oFAl16ErcFCQtGkwkACgkQjg6d67x+j6q7zA/+IsjSKSJypgOImN9LYjeb++7wDjXp qvEpq56oAn21CvtbGus3OcC0hrRtyZ/rC5Qc+S5SPaMRFUaK8S3j1vYC0wZJ99rrmQbcbYMh C2o0k4pSejaINmgyCajVOhUhln4IuwvZke1CLfXe1i3ZtlaIUrxfXqfYpeijfM/JSmliPxwW BRnQRcgS85xpC1pBUMrraxajaVPwu7hCTke03v6bu8zSZlgA1rd9E6KHu2VNS46VzUPjbR77 kO7u6H5PgQPKcuJwQQ+d3qa+5ZeKmoVkc2SuHVrCd1yKtAMmKBoJtSku1evXPwyBzqHFOInk mLMtrWuUhj+wtcnOWxaP+n4ODgUwc/uvyuamo0L2Gp3V5ItdIUDO/7ZpZ/3JxvERF3Yc1md8 5kfflpLzpxyl2fKaRdvxr48ZLv9XLUQ4qNuADDmJArq/+foORAX4BBFWvqZQKe8a9ZMAvGSh uoGUVg4Ks0uC4IeG7iNtd+csmBj5dNf91C7zV4bsKt0JjiJ9a4D85dtCOPmOeNuusK7xaDZc gzBW8J8RW+nUJcTpudX4TC2SGeAOyxnM5O4XJ8yZyDUY334seDRJWtS4wRHxpfYcHKTewR96 IsP1USE+9ndu6lrMXQ3aFsd1n1m1pfa/y8hiqsSYHy7JQ9Iuo9DxysOj22UNOmOE+OYPK48D j3lCqPk= Message-ID: Date: Wed, 22 Jan 2020 14:58:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200102234907.585508-1-alex.popov@linux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.01.2020 02:49, Alexander Popov wrote: > Make the stack erasing test more verbose about the errors that it > can detect. > > Signed-off-by: Alexander Popov > --- > drivers/misc/lkdtm/stackleak.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) Hello! Pinging about this version of the patch. Kees, it uses dump_stack() instead of BUG(), as we negotiated. Thanks! Alexander