Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4812213ybl; Wed, 22 Jan 2020 05:14:45 -0800 (PST) X-Google-Smtp-Source: APXvYqxjjjKq+GEpyS0E1//A+L05CE8z4TI1Z9TNrANAUP9WJwussnHvUyBSDscaVVsQvSrWt8b4 X-Received: by 2002:aca:dfd5:: with SMTP id w204mr6820038oig.95.1579698885353; Wed, 22 Jan 2020 05:14:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579698885; cv=none; d=google.com; s=arc-20160816; b=Prd2tSwCHnDwCq41vtnEnVnZS2GsZj9AezQQUntVV+a8v1FxgO//+oR7Ok2GqDZ2x+ e+IJqm6wEQlhMgdacaz4KSNqtSSluTSqko6GPw8R37MGD/KDxAmSf9taO+1uFJMmhfBL uXFcB/BbnjGOtw0rlnKg51f0iE0FjF07nWWE2tCCjKKLscFWAjSYkITm8XWg4g6TMK0d 9N5aDWL7sdxen9kXUHnuocf00bCP5kH/ZHYjxFTMpdkU5tmAKgBWHoodoFICvyBXkwaD PaW24PERiRdYJuj08NRxOTyCw3fbshfQnP3ozEbaA5izQgREP6rFdrJ3IUPUXZeJnP8E i5tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=X8XNzOMi/n+dQeJrbwdw7sdQnb7CNeZ4/rdEr0e9YSk=; b=xtnNBxi+rQB4cc7owpGNSM3QXz9YTop1hNb97TlDq+WtztqsTYyPjpxUJsKvuTnH+7 d7ef4gEsXfagcj7xeQoeTAuJFU8cu+jEkdZsqW7MBR6BSKjAD7CRb4oZu4YeprVEnITH LjV2FpV8JcP0UJvIXV29QagDDwRe5O5DmEYCm6EBm3rsrtAvYcCWEnpCsM2344NG2xZY VlZFcra3akm6SjFvmvAK+X8O8V1lE4LkCwCldSFBSD4yGTUBBmvK/dlFb23L4RoKhcgm 39vKXch+pl0ZCgEjLMDb1GJpaX9FWW24IMD01IpT3utr3She7bJqIHZb+yqyq4+M8HIz th1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 25si21041075oiz.230.2020.01.22.05.14.33; Wed, 22 Jan 2020 05:14:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729187AbgAVNNX (ORCPT + 99 others); Wed, 22 Jan 2020 08:13:23 -0500 Received: from sauhun.de ([88.99.104.3]:40682 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgAVNNX (ORCPT ); Wed, 22 Jan 2020 08:13:23 -0500 Received: from localhost (p54B33378.dip0.t-ipconnect.de [84.179.51.120]) by pokefinder.org (Postfix) with ESMTPSA id B256B2C0713; Wed, 22 Jan 2020 14:13:20 +0100 (CET) Date: Wed, 22 Jan 2020 14:13:20 +0100 From: Wolfram Sang To: Rishi Gupta Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, wsa+renesas@sang-engineering.com, gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] HID: mcp2221: add usb to i2c-smbus host bridge driver Message-ID: <20200122131320.GA20984@ninjato> References: <1579581860-29560-1-git-send-email-gupt21@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <1579581860-29560-1-git-send-email-gupt21@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 21, 2020 at 10:14:20AM +0530, Rishi Gupta wrote: > MCP2221 is a USB HID to I2C/SMbus host bridge device. This > commit implements i2c and smbus host adapter support. 7-bit > address and i2c multi-message transaction is also supported. >=20 > Signed-off-by: Rishi Gupta My main concern is there are quite some limitations in mcp_i2c_xfer(). Looking at them, I think we should just drop it. This seems to be an SMBus controller, not I2C. Or? --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl4oSmwACgkQFA3kzBSg KbYUUQ//QRTq13acJjQ3rK7tv03qoLYBTDze3sLkt3dr/yc6ZTQAlXxHGEWdCAzE zGI4hOu0rpLt+Rm1KQsQo/FDgU7fy4BXSi9oe5zr5TPRctWVAV3MpcqRq0CIRDwP TcQ7QsXawtCRtwhlOOVzYMqK8DOkeXQncs0qT3ilqpruBA5gbmJanMyVpNU9hQMG i9fYTdYNBgnydG7TqvCA5Vn2hOQuwIJjt/vNFhDu5dum9koKe+K3P1Ns7TtqeCcA xB4YL0eQydWNrS0U0nKQoT8L7cwWOwQEa6Nk6zKLIsKRLFbYdQu0KpEBi+KEmzCC jXHL9B221rG6fvgDp0VaPCRrQzdexgu2tIAH2TQHVReK9+wZOFVIvz135Y3lj3sR TcORLIPjziA62yQwTWA839liZEYlAAyEcwOUL0U7w7TYMu49SJ0o79nj+Skw3kUt SwSqq9LLlWO7UJ09omKhikj3zgfBGz7e9V4dCUqZLcSntGEK3yDZBFqXwKGqT3sd GiAEZu6zocdiZxX5CdUQhJQmUMJHNqD/xYTS6PqKwIu/Kg9jffUgwylV+j4Pmbv5 m/cetIceeRk3DXZ2RUCt0KZBg0UrwueiuBYetiETINRkgDlzNI9FjHYJROFN61ph ux8Dp4L2SaGrwScrrH+2fiQdpl3RBDNYG7L1ssJCLjXN6pW6jvI= =hhi+ -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--