Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4818206ybl; Wed, 22 Jan 2020 05:20:34 -0800 (PST) X-Google-Smtp-Source: APXvYqx9nwWhZK0MTnuaEESUCeZAKNxaHdE/gd5/EWK3lCF9zY/lwIuf34lDQGMCYXYXs7iiGPPf X-Received: by 2002:a54:4713:: with SMTP id k19mr6682417oik.113.1579699233788; Wed, 22 Jan 2020 05:20:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579699233; cv=none; d=google.com; s=arc-20160816; b=ebcp37A5EH43ngegMuRTkTn058ei+iJBbMbEvYfB8qlGduRdYc0h6rJen8OmrSx8Wt ccR+c2EO3oKOEcnFfH+bqc4MBhg5apJNS/k43oD85FPB0l0LwL0mgJWtQRyJKPQOXlmS FnpS3Nkls7+FqFP5zQ4Lijs33UCioMHvVM5kMd1T+ck4UQ1j58xaIHimCr6D6D3sLDUF d5wWGpw8vfmV3X0KswdCJJEoHVcD4NVTlDCYqTJvGFmZkcv3lGiEf0tWTgWQMRAR1OPG etOnWtwRs3WgG3Yd90JKOD5M0G1nQG0uMOejsSSwAGv6M9oEwkKGAkrKi4vmQzirD8rP Zdag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=2lJ5QNgwpRzOQbAxO/609U7b0x37hAivNqISTiD3HWo=; b=vd/468H9rG7gS8HEAvaQbj1f3UJbbt4PJgmgnNq2cwWwDRqmJf7+IMEAUt0Q8oZPko 9fUHJWfCemu+aAac3reC5m/VEhme9lZ/dprVCgzpEzGVIdn/mYDJG88cp1VuDtOh/27e sm21XlzIqjdiAcRpXNXLvKNYROMoAnL07jPfFW1vjcrgOw/klG9idGUnJ+/HkZfSfXqQ Z5fPh+KSyhcYhxv2bJlkqf5IOZehpe5RVt1Kjs1lKC22M7Q+iWsFPIN+HRFdhvWhMI8w ArQVL6aVl/+VzjWxfzTfzAQE6MK1XuJKtvaWXnsVxn2GWeKtDod5jzbJoCeteUPRj1au 36fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aYOfRDZ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si24699319otl.54.2020.01.22.05.20.21; Wed, 22 Jan 2020 05:20:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aYOfRDZ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729486AbgAVNS6 (ORCPT + 99 others); Wed, 22 Jan 2020 08:18:58 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:46332 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgAVNSt (ORCPT ); Wed, 22 Jan 2020 08:18:49 -0500 Received: by mail-qv1-f65.google.com with SMTP id u1so3151807qvk.13; Wed, 22 Jan 2020 05:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2lJ5QNgwpRzOQbAxO/609U7b0x37hAivNqISTiD3HWo=; b=aYOfRDZ2x/NIOkNxI0T5WwT9IKeenQ5Qj5QgjdSkvzB9zaLSPrFkdcP75g6PBgCUHB BjIFsqZVRyzDuGwoR0j6al2mPKgqO+GbTPu1LVjvaX2gOB1riGK/AN40r3hOtQM0pjv5 JALRRXGAsu602xHDh+pTHWbYigHkO1rlKZZbAbE6GzAX8P6aIrnt50UuVG8+JmsbPcH0 6YFBlNB596A+EuYvCJihR5OXrYrWVuXzYJQvjFgLATyLcO24tLeMxi6onhYovyCOp2dZ u8XazXCECVBembnkGztqlsVWhdjGj50kfaS4MuIaX6s6ZmtYLcPGjCGKhBn0Ztr5dFyq xR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2lJ5QNgwpRzOQbAxO/609U7b0x37hAivNqISTiD3HWo=; b=C1/+h3GkJX4+flIkCC63Dqguq7KamjC98/Dk8Q/josOyCnPEUDmeBPOylXyMHPOdEq RNv+duaxobsGgyljexljpm1IK5TS0Y9+EDMMfZN5as6iDuFqNx1Tq9GIrejLx3zPTN6U WsYSh9P+atkJ1+YqkgjzVJQ5cbNSIIrFm65vbe0IfXtlsY+D6iIJMBtv0k/R2GuUgzCZ NBHiLJlPQPFv27NjAtJnEkQ1O7bbCMR77jDSo049IPnhnBRszjRRPUFuX+dS7rnEumbl w+0bTQHpjylxNHBEJ3EzMC/d5amM/kUfJepUfc1jp3c8c6G5Kjox3RPG9oT0ZkEUEZ32 xXhQ== X-Gm-Message-State: APjAAAVT/wIB+UMcXwplquN/eOniQCCKlBuEVcToreS0OSLabvVKi0SD LKBOcrJBNwkEJDx15zo+PpYvkMxukGPARUM+XSc= X-Received: by 2002:ad4:408c:: with SMTP id l12mr10445440qvp.164.1579699128301; Wed, 22 Jan 2020 05:18:48 -0800 (PST) MIME-Version: 1.0 References: <1579581860-29560-1-git-send-email-gupt21@gmail.com> <20200122131320.GA20984@ninjato> In-Reply-To: <20200122131320.GA20984@ninjato> From: rishi gupta Date: Wed, 22 Jan 2020 18:48:37 +0530 Message-ID: Subject: Re: [PATCH v2] HID: mcp2221: add usb to i2c-smbus host bridge driver To: Wolfram Sang Cc: Jiri Kosina , Benjamin Tissoires , wsa+renesas@sang-engineering.com, Greg KH , Linux I2C , "open list:HID CORE LAYER" , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is both I2C and SMBus. Title of the product itself is "USB 2.0 to I^2C/UART Protocol Converter with GPIO" https://www.microchip.com/wwwproducts/en/MCP2221A If I am mistaken in something, please help me with specific thing so that I can dive more from that perspective. On Wed, Jan 22, 2020 at 6:43 PM Wolfram Sang wrote: > > On Tue, Jan 21, 2020 at 10:14:20AM +0530, Rishi Gupta wrote: > > MCP2221 is a USB HID to I2C/SMbus host bridge device. This > > commit implements i2c and smbus host adapter support. 7-bit > > address and i2c multi-message transaction is also supported. > > > > Signed-off-by: Rishi Gupta > > My main concern is there are quite some limitations in mcp_i2c_xfer(). > Looking at them, I think we should just drop it. This seems to be an > SMBus controller, not I2C. Or? >