Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4823243ybl; Wed, 22 Jan 2020 05:25:33 -0800 (PST) X-Google-Smtp-Source: APXvYqzRzo22uZfu+sFDCIQEfqzJbQhOX5Ts22TAsIUuZdxJcnXsHTPdaxTSgdrDQKoUS9eadEFq X-Received: by 2002:a9d:4d90:: with SMTP id u16mr5044576otk.159.1579699533584; Wed, 22 Jan 2020 05:25:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579699533; cv=none; d=google.com; s=arc-20160816; b=zcEv89MT7w6mtGXwGb3hYp/GCIEpk5RDBww5datf0FbF9n/rjhI34LBXCtQ0X7+b7K nDSQAsUPd/mVmfI5/2E9hb4BK4LvWh8jk535dKKF0wQe+RyceeEWuskgp+ns1qs0DFi3 C00R3ang7HKxZZKX65YGLfwo9FrYtuiqsW58OXRuSBx8c89LWvF53F1GDN3Iaj5h/J54 /zT6EIFHwFem1U641Yfnt8sy7HhSY2HyLb0PHlv8VnD0BI5ZreZspYvI7pZqhRanmbj9 ChRsXRTFOdDlj8qw6+2lntrj8MZWW08Db9U79i1+cooDLa0ghrbqHiHSmxZwQlSJ48tM j2+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HnrTI7IeGdydR9MJqqd8XkwdR6dG20gNJw0QGt86Jto=; b=x73zMpwImshvjeVXc7gUv4FiTOxaiZE6UPfOg6zvYldjU+PPxOV/2kuMZtoBs2+7wA EY37y0Y9cS/vw+FM4ZsxuLjnZOIwkvK9FUu198t/iLzwDNK+UW80GVSfu2CpUZxJC76b bwRecDFx7nUz1CYtT8gNSMq8gNf4y6QNyC/hYHljDWzwpJzI6qgeqwWM7EGoR53NO5+S WrUcYuNJnEJzglrNNX517BuhVIqKI28TkcFUtYBX8nxN1Je7q+5bTJuaT0072Ci+q7Mq WN4MgvAMtp7fHv5u0r5kzypee53eiQnxIKcYkZaWQLl/A8IbMnFuoz4WBORIorow/MYm T0YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="DQU642j/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18si24909874otf.285.2020.01.22.05.25.22; Wed, 22 Jan 2020 05:25:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="DQU642j/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730992AbgAVNY3 (ORCPT + 99 others); Wed, 22 Jan 2020 08:24:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:43398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729151AbgAVNYZ (ORCPT ); Wed, 22 Jan 2020 08:24:25 -0500 Received: from localhost (unknown [84.241.205.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 905532468A; Wed, 22 Jan 2020 13:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579699465; bh=q2Ktr8oEsKQfbcS/mb8ot+UDb6iWm9eHCebzprgScec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQU642j/bc7AYTlj2oIhKMt5q9QjC2NrTghB0s8HGAXSwfnVsmYXo0uPZHaZOh2EB dwG8WQvDofQ96AtY47BrQ7I4JiiMrv5NUdRM2ttNtI0aiKPLNO+TQH31uP8oILTMA7 Cm1RmAnvbzEuicn2zh7MHG9KiN0VNIgjSuzdeYG8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Markus Theil , Johannes Berg Subject: [PATCH 5.4 118/222] cfg80211: fix deadlocks in autodisconnect work Date: Wed, 22 Jan 2020 10:28:24 +0100 Message-Id: <20200122092842.189163287@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200122092833.339495161@linuxfoundation.org> References: <20200122092833.339495161@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Theil commit 5a128a088a2ab0b5190eeb232b5aa0b1017a0317 upstream. Use methods which do not try to acquire the wdev lock themselves. Cc: stable@vger.kernel.org Fixes: 37b1c004685a3 ("cfg80211: Support all iftypes in autodisconnect_wk") Signed-off-by: Markus Theil Link: https://lore.kernel.org/r/20200108115536.2262-1-markus.theil@tu-ilmenau.de Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/wireless/sme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -1307,14 +1307,14 @@ void cfg80211_autodisconnect_wk(struct w if (wdev->conn_owner_nlportid) { switch (wdev->iftype) { case NL80211_IFTYPE_ADHOC: - cfg80211_leave_ibss(rdev, wdev->netdev, false); + __cfg80211_leave_ibss(rdev, wdev->netdev, false); break; case NL80211_IFTYPE_AP: case NL80211_IFTYPE_P2P_GO: - cfg80211_stop_ap(rdev, wdev->netdev, false); + __cfg80211_stop_ap(rdev, wdev->netdev, false); break; case NL80211_IFTYPE_MESH_POINT: - cfg80211_leave_mesh(rdev, wdev->netdev); + __cfg80211_leave_mesh(rdev, wdev->netdev); break; case NL80211_IFTYPE_STATION: case NL80211_IFTYPE_P2P_CLIENT: