Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5114876ybl; Wed, 22 Jan 2020 10:34:27 -0800 (PST) X-Google-Smtp-Source: APXvYqx0KKoclIZE+Y6zaZS7o1lVNKQmJBYn/8S3yKei7wW3XCxfoFYdJiXFUvRjhN35Bjn0unM7 X-Received: by 2002:a9d:12f1:: with SMTP id g104mr7962271otg.149.1579718067780; Wed, 22 Jan 2020 10:34:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579718067; cv=none; d=google.com; s=arc-20160816; b=uhIrzDFq1RVf9vnFCR980Um2xSEbAsCgB0BmFsnVW3vpk5cIwd1kwANKbRqjq5cbnh oRY70YLMuXclEg9nHyK4H8wm2E8Xyg0WYS5GPybhblesXI2ph6Y66Qxi3x12TOqlJg4t 2GXzMnBkzwU8qvQne0Vq790TCDFl7JEZyz0gu3pP7mlh0VtEPuqHKTtk0OYi8ZgQq8gF 6zpdB7CWae65CSWc/Dmgoet+JbYN3M2sjKoZsjxzWrfJpAlS/fb1StuMIoLTCZJpsa3Y xaR3ccBNmzWxR1rt5QM+N+3se9dnxor8RuzaqlC27l6zknefC2PTAC8vjHOtJtHNsaF9 5nvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=gw8I5aiIUaYpdf0ZjnC2yPzUYsG+Rx7Jxl0dmjPEBa4=; b=dlJYhbDki4LpvPn6BR6Uir2pI42+QqTL17UeSMKoNkdwSgXmiF0siMibSp+OPpMWYf 6f55/aXRDMY1KjZqmeGqRpdGgu6XvgCIwNGqvpdNN7JpHg1ZVd8oNXQq9Z75A7Sz7oTu EldPHnHCCEb3Slu2H94RDHqHL4y6eMcfzqdIg+YUg3yiksODlv8HCFbgWbIt7d0Z6+En cmoFActZ5kbQ114SZmUS8eShIPlq/fpPgIuVwT0gyJcIRfDwoqVT5B1D55pwe/PHHxld J86OzPRGCQSnQM/0wIUdARG40a18KicG6L4o8w3fqskCzW2fvCSo6MwjrBfOIGG823du tHBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8si13638735oti.47.2020.01.22.10.34.14; Wed, 22 Jan 2020 10:34:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728139AbgAVScJ (ORCPT + 99 others); Wed, 22 Jan 2020 13:32:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:40872 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgAVScJ (ORCPT ); Wed, 22 Jan 2020 13:32:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CA74FADE3; Wed, 22 Jan 2020 18:32:05 +0000 (UTC) Date: Wed, 22 Jan 2020 10:25:11 -0800 From: Davidlohr Bueso To: Alexey Mateosyan Cc: Andrew Morton , Al Viro , Markus Elfring , Li Rongqing , Arnd Bergmann , Kees Cook , David Howells , linux-kernel@vger.kernel.org Subject: Re: mq_notify loose notification request on fork() Message-ID: <20200122182511.uf4x6q5t5zelwi3g@linux-p48b> References: <20200121185250.fk6nkcw5nqbkab5o@linux-p48b> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200121185250.fk6nkcw5nqbkab5o@linux-p48b> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jan 2020, Bueso wrote: >diff --git a/fs/file.c b/fs/file.c >index 2f4fcf985079..70e5fe1c70d5 100644 >--- a/fs/file.c >+++ b/fs/file.c >@@ -440,6 +440,7 @@ void exit_files(struct task_struct *tsk) > > if (files) { > task_lock(tsk); >+ files->tsk = NULL; This part is wrong, of course, as we later need it. We can just remove that statement. Thanks, Davidlohr