Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5236973ybl; Wed, 22 Jan 2020 12:59:50 -0800 (PST) X-Google-Smtp-Source: APXvYqzF4+3xCqIzgGd0UYhTkKyOy6jL4GRRCmyMyKT2TcTkE47bD3sBhju8JwR4xJSqKiOAYTmK X-Received: by 2002:a9d:4692:: with SMTP id z18mr8666491ote.163.1579726790172; Wed, 22 Jan 2020 12:59:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579726790; cv=none; d=google.com; s=arc-20160816; b=Uloz7xLUkpwvZFut2DGHZzJ6dcoyFbFGPpqZTA6e1yO6TUOPmTcLGB2mfWrN3PTg7A +NKVCBxvI0cM0kCvbvKFbmdffDUm5xSZfmA7zr01Onw77lw3uyw4foCS4K/YRxk2fAFM piI6AClRbzul3ULqtDsSieMWScJVit7DnwpdGHclN43uLzZ7vlFjI6NGCBt9u4WjqgV7 7VULenB1sg5b5kLtY8A9EDXJvgjJYHv5YgtiZWHV2SGnL/Qh0BFf07lLAo5J/lBQoCsq ppymzP0qJ8d9ilPGQdT7KvYvFP3iD7YP/ywRHx0Ra6SWlpZavJZJdeQpW/p1dNnr/3mV 1MhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=4MircL4o+/KcGaydQPkSmj2rWDThvm1wQe092xveFAg=; b=SaUDA3kJKtD5bt2eirXPx09Shsomm6vLe1XJSCwHZN3Du6WfyEjql5WcYkZRr1b4CF 41JuTuKRHR2aLYFWpJGQnkH5eOZCkBdMqIZHWLg10IV2XvBUIuxWJub5dXRP8cmuqZpk sbdCKfL9t8LjVhDOxdR11MtxnRn85QggKcRHZ+tCptHKnJ+/I0c829ClLbGdyKKgN/3m DvuYmKA9SQpNbpULy5UOpifXGNEjGfkl+hDWTaJ/w4rDL/0haCQB8hBAyedCkoqhv6ep nsJGn0m+VhR7Q6qh3SNjoQKF0fs845ytpWjtuoxYI6jP4tuAz4JbemW0JlJAWwjEPtEp 7xvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=z7zNVoDL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si22390413oib.246.2020.01.22.12.59.33; Wed, 22 Jan 2020 12:59:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=z7zNVoDL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729066AbgAVU60 (ORCPT + 99 others); Wed, 22 Jan 2020 15:58:26 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:33124 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727590AbgAVU6Z (ORCPT ); Wed, 22 Jan 2020 15:58:25 -0500 Received: by mail-io1-f66.google.com with SMTP id z8so756400ioh.0 for ; Wed, 22 Jan 2020 12:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=4MircL4o+/KcGaydQPkSmj2rWDThvm1wQe092xveFAg=; b=z7zNVoDLPM4MKPRvTM8UcJmi0wu+n3yp7v7+XP9SWb4hRXrNU7h3WCwDGc1P4vU/pr 1RDsoi29ohD4qtUcHvQ8YVj3VQwls6+TFceX3zfd6HPZyLZ5d2nUYL1gwbItGly6YDQ/ S2NtkRpr/cc2n/3SgaFMbvs0eS168OjavvQHzbbqmK4j9iFfDgQTEmS2mHsV2YW0RcMW zcBAMt6NxOf8u0r10Zm4RBnrYnA+JWTjw0JMqfRjiaz0aHpWK24OVvrAWbwynBgiDRUy W+ArAyPuMeakUhlPKLAWTElfVmnwEmTSFh/F8/UOvrdl3yM/7qU6GShXUf03Hoy7DLmn ORLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4MircL4o+/KcGaydQPkSmj2rWDThvm1wQe092xveFAg=; b=QoOjfi5d+O4pdAV0+OOVH3e09khzPsPZHVVwyJrH07Q3umTmhqXglh0WjAtUXkssAT lOyE7lHGPcI2Wo33S1vT/sWQGn7zc1qw5EvOZopk4HKQQKn6eEOBtIz+Tjo4/fvBfKE6 JhGurddhJE7L85tZ/hEykr35ZJoyrxs4xsg6MZLgS1+otj9zZlL6fblllA9S09BbLkig 2aZyHAfRuBkmdOOGvE0q/+oi8/LEpgX9V4Ft6eCflyXHMqjY7ovnFRn3k5h//8p41TNT H2qtcI4/+9ZCOXk8FPff+S9e5REatPqsc5PADlxA1aPv12vcCiui9IT1GmKbw6JnUrDu a9/w== X-Gm-Message-State: APjAAAX2H63t66Gn4dse9HgfuM8fQBYUoz7ky0JkwDXnbX9N4Us5I3rU r6kshL9MvlvXjJ9hvu0LMpv1flPQshA= X-Received: by 2002:a5d:93d1:: with SMTP id j17mr8768497ioo.300.1579726704741; Wed, 22 Jan 2020 12:58:24 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id g4sm15020839iln.81.2020.01.22.12.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2020 12:58:24 -0800 (PST) Subject: Re: [PATCH 0/2] IOSQE_ASYNC patches To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <5722c4c7-ac5d-9a28-62e8-c327c6affc3c@kernel.dk> Date: Wed, 22 Jan 2020 13:58:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/20 1:09 PM, Pavel Begunkov wrote: > There are 2 problems addressed: > 1. it never calls *_prep() when going through IOSQE_ASYNC path. > 2. non-head linked reqs ignore IOSQE_ASYNC. > > Also, there could be yet another problem, when we bypass io_issue_req() > and going straight to async. Thanks, applied. -- Jens Axboe