Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5275992ybl; Wed, 22 Jan 2020 13:45:09 -0800 (PST) X-Google-Smtp-Source: APXvYqy6/izaNaAoP4bAc0e0D5t3NtIYRNnpHSU0e7lOSWFkUwHFTnHcsN0X+NADJbOUrihtBcfS X-Received: by 2002:a05:6830:1e2d:: with SMTP id t13mr9295003otr.128.1579729509185; Wed, 22 Jan 2020 13:45:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579729509; cv=none; d=google.com; s=arc-20160816; b=xOTVVcaQMNbpl5v+C+n+xf+vboT9/hHYfLXDZlfmu41GiaxWUcZeY3bvoYOO638ZhS mOSzwilsEVPB2WDZT5XSnPXg0Ojc3NpXvNxBQfyNHJypNqLj4crlBd8dAlqnA7rxXDz7 apV52YDLdK7kjFEvD8ipkGyq6TpHWha8DwWAnp3Nb4ijR9Cane7AtTMldgisx0/bF3gg T3rQelcOcBwcbIeYndwO2ge7sU/uulPCl3Np+CBuvYm1KtX/O4pLgIvPh6QGVWAzGD9N A41aZ/XevH/nNWautkloNJETjPib3/BJlyb5LjK0HXh7QfWDtLICoXJOov/ZYApjBljG ixrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=P6YIyQ6H1J0k+Mrn2boNE7EpN97Sppw4ebAkqT27uNM=; b=wZiUvzNQ8ieWqLCEeaip4GKVNB5bk5u8CDUEgzf8vZ2r5xPq50SN8HO4Gcp2enS0MH ZXz5gbEflbPf+sncw5I+j8qo+pMvW1Abl8AQGD6opZQuWk0KZtvrgo3KQvcMG1ZFkL3k XRACu1pGiKbyUwo11cPe8WP7I9/ruR3uy1UeN4xi/jd0SdTPXHcFJVEXLGnvapVOlDbp ciRk4HX+UFSk0Ggkpnsf6KnGWmE9wWfw1JgFo9dKefqrWvPh+NlP9vA1mKRBz2+3yCkC Hu8jUQhrcFeDr6WqI8Gv0S9eSWSxi/Ko0bhpfBLTbfH3uYXZzinvzOVXG7oBNXW9g/XB U4JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=IDYVCYAu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si21841760oil.188.2020.01.22.13.44.55; Wed, 22 Jan 2020 13:45:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=IDYVCYAu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725989AbgAVVns (ORCPT + 99 others); Wed, 22 Jan 2020 16:43:48 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:60576 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725827AbgAVVns (ORCPT ); Wed, 22 Jan 2020 16:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=P6YIyQ6H1J0k+Mrn2boNE7EpN97Sppw4ebAkqT27uNM=; b=IDYVCYAur0v9GQiVU1k2QC4+/ 60NNV/9+0ms9oWTt3Ipheguyza66RVtsYZdx+8r+lZ3392jy/yGAEUVS/7lqy3+K6fYsjBOOjzSbO n4obXzw99QKagw8C5iTj4CH8Bad+At9QYnQ0mVrcNu3fgKmAHQmqqbfzcduZtHqTVZhsecjE6y4hA ujq9qIzusK9xiodEnOOQ64Eh7mh5HFfWMQyJzLKBsmp09FJyJODw6qfyXCkeLZgzWcen3V8IsAc4b HiGBzDcmrVEMFnPB8ir7Yq1p/Gr909/Au6aUSAe38rbZK1tgM07qRG7qjnyq+4EjetSpa8OBrwH54 jAmo+Q0wA==; Received: from [2601:1c0:6280:3f0::ed68] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuNmt-0000Ns-7r; Wed, 22 Jan 2020 21:43:47 +0000 Subject: Re: [PATCH v3] dynamic_debug: allow to work if debugfs is disabled To: Greg Kroah-Hartman , Jason Baron Cc: Will Deacon , linux-kernel@vger.kernel.org, kernel-team@android.com References: <20200122074343.GA2099098@kroah.com> <20200122080352.GA15354@willie-the-truck> <20200122081205.GA2227985@kroah.com> <20200122135352.GA9458@kroah.com> <8d68b75c-05b8-b403-0a10-d17b94a73ba7@akamai.com> <20200122192940.GA88549@kroah.com> <20200122193118.GA88722@kroah.com> From: Randy Dunlap Message-ID: Date: Wed, 22 Jan 2020 13:43:46 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200122193118.GA88722@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, If you make any more changes: On 1/22/20 11:31 AM, Greg Kroah-Hartman wrote: > diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst > index 252e5ef324e5..41f43a373a6a 100644 > --- a/Documentation/admin-guide/dynamic-debug-howto.rst > +++ b/Documentation/admin-guide/dynamic-debug-howto.rst > @@ -54,6 +54,9 @@ If you make a mistake with the syntax, the write will fail thus:: > /dynamic_debug/control > -bash: echo: write error: Invalid argument > > +Note, for systems without 'debugfs' enabled, the control file can be > +also found in ``/proc/dynamic_debug/control``. Mostly drop the "also". How about: > +Note, for systems without 'debugfs' enabled, the control file is located > +in ``/proc/dynamic_debug/control``. > + > Viewing Dynamic Debug Behaviour > =============================== > -- ~Randy