Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5309425ybl; Wed, 22 Jan 2020 14:27:54 -0800 (PST) X-Google-Smtp-Source: APXvYqzFkbP3PVIxZYCWrc4jM5gWliDZPq2gV3Vgdo73pGBFvVTly2dJ9M2ZJdjKKcpWGLkUPKF4 X-Received: by 2002:aca:4ec5:: with SMTP id c188mr8726879oib.1.1579732073961; Wed, 22 Jan 2020 14:27:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579732073; cv=none; d=google.com; s=arc-20160816; b=BpC+WEO3kx7FScVZrk4qrsRr2m+1OSvG2EruGuZG0fTakJItXf6HPzaGCb/7sZ6PVq 3cdwhAJ0O4BpCQ1WKuv8F9ykrOkKB5bD4CXMgEM+h232NQjeyGbM+Gcs2Ef756ayhVS6 4p9KEzpXGGKbYpw34JWDpTtBl958E5w+CYjvRl5HUzv/GhMFuxlRwix35CHrO+Pgu6Tx ucpLIKwgYk/X74oDnmJtHpkX+Di5do6bb4elXJYa9/NmsgzTfpcEV5Y3i1WjVzp8alXS lKNjgduUKs6CvPdWRYGVyBymPi9hV9+/oeegHdpP9d5U+batEzJxnZraIgPuFYrGtduf xsrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:date:subject:from:message-id; bh=iT2iwv4FpC4vzpzKee5Mw/wu2RH7DfAOJJ0y6TuJjzM=; b=eiFfCJs03f5Tb6zS7pgdLyF+6dWPN/gn1LH3996lW6Q+9xHjj6HvVCuGSNJgs6CpFr VS2WWDhUm17/f4HJXfYFmEhUbZ5r1RbFxw8mTF2I7upX8JGdyxCc9aHGS+cjlkavdHZX OHvlGy/gLr65Q6fZzP5uaIi4ffZqs4ujCHK+iHI30T3fFeEAaUZkOrX4QxQKOvHTxZmx 1s9mUQ3Zzjg5wa3nf+CddgC/NcjVDxhaQpdOX+Vd8Gl0Uku2qBPmHMZviKAykIMdwFBv S8PQsC4vqZTswisxi+qPsKuHSlHibbn4l29AS+cBnQQJWcr46P55L6AtoD+692Unvllh 1YOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q124si22302868oig.228.2020.01.22.14.27.42; Wed, 22 Jan 2020 14:27:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726232AbgAVWYC (ORCPT + 99 others); Wed, 22 Jan 2020 17:24:02 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:47744 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgAVWYB (ORCPT ); Wed, 22 Jan 2020 17:24:01 -0500 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 16A7E299A4; Wed, 22 Jan 2020 17:23:59 -0500 (EST) Message-Id: From: Finn Thain Subject: [PATCH net v3 00/12] Fixes for SONIC ethernet driver Date: Thu, 23 Jan 2020 09:07:26 +1100 To: "David S. Miller" Cc: Thomas Bogendoerfer , Chris Zankel , Laurent Vivier , Geert Uytterhoeven , Eric Dumazet , Stephen Hemminger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Various SONIC driver problems have become apparent over the years, including tx watchdog timeouts, lost packets and duplicated packets. The problems are mostly caused by bugs in buffer handling, locking and (re-)initialization code. This patch series resolves these problems. This series has been tested on National Semiconductor hardware (macsonic), qemu-system-m68k (macsonic) and qemu-system-mips64el (jazzsonic). The emulated dp8393x device used in QEMU also has bugs. I have fixed the bugs that I know of in a series of patches at, https://github.com/fthain/qemu/commits/sonic --- Changed since v1: - Minor revisions as described in commit logs. - Deferred net-next patches. Changed since v2: - Minor revisions as described in commit logs. Finn Thain (12): net/sonic: Add mutual exclusion for accessing shared state net/sonic: Clear interrupt flags immediately net/sonic: Use MMIO accessors net/sonic: Fix interface error stats collection net/sonic: Fix receive buffer handling net/sonic: Avoid needless receive descriptor EOL flag updates net/sonic: Improve receive descriptor status flag check net/sonic: Fix receive buffer replenishment net/sonic: Quiesce SONIC before re-initializing descriptor memory net/sonic: Fix command register usage net/sonic: Fix CAM initialization net/sonic: Prevent tx watchdog timeout drivers/net/ethernet/natsemi/sonic.c | 380 ++++++++++++++++----------- drivers/net/ethernet/natsemi/sonic.h | 44 +++- 2 files changed, 262 insertions(+), 162 deletions(-) -- 2.24.1