Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp154266ybl; Wed, 22 Jan 2020 18:14:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxBlLsiezZiv1R/rFQNQQhe68IB1edmSNSgbUImJBRF2SAsk4Put0pvJqNCE9GHG/U9y+8o X-Received: by 2002:a9d:4e99:: with SMTP id v25mr9912983otk.363.1579745698694; Wed, 22 Jan 2020 18:14:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579745698; cv=none; d=google.com; s=arc-20160816; b=NP+0FsFYU4R7aRxxuU7mYNT1kGWZtUx6fdMoY9vOEL4S/XaIs/T8bOlwL3GAf6YRW+ 6iHER5duaRJJyzla/aXJyVbgbNXqjj26S+zHylTIGXMP2wr6yzHWsBQivIHd5mZrrbWt jm+1fD02sUFD8qvot05s2oEVNr0L8utLfIeWN8m5kx7DghdDzQ7a7jEz31OOE+0SGUrz 9OBSDMqo/n1RL1HszTxoeuELtXsWfNy14IHAJfDX/Z1/VV7+mHm+Qy7Z6JPk+nxog8D6 U0bm/U3i4CYDPyttzWBhO5blXMWZvOvugBqgXE0eZltq4cesoUeci+lHsFxNUoq4OXg8 Qqyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=HSZLJHaxiDRdE5kld4O3wE8BZ4k4mVCAU7VWi5Dw//8=; b=Q601jCz1Rhx/upASWeXO5US4dTFNJhEyBGYa6+2KdYCZ2Ux7YAIqw9Z7A8lPs8Z8qv ealaf4wusaKx0v0/vtKizjHvWxsZ7Zk1xnocQc/yxl/TwZrZGsN4HV2K2FJoPJTziXlq Hk57Ngr6uzy4jcylb78K6riG1AGBXQfXTY7DLMXZLCX1saQ719JJ4IQOc2GNqdy/d/tM qaxG3XjrRbag1SAmfVl9fd3zmyqQ+B2G1vSnnE9UavfJLXTgqYz9THai1zoLDLjNDMHn Q1nZETVVs78sZmVvE7sXNB6lymOCMT89p/J42D6X+Ru7haKFDPXg0xckoJBzPfxbNG3k D13g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bDZDIFzZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u84si180634oib.34.2020.01.22.18.14.46; Wed, 22 Jan 2020 18:14:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bDZDIFzZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726054AbgAWCNt (ORCPT + 99 others); Wed, 22 Jan 2020 21:13:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:44922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgAWCNs (ORCPT ); Wed, 22 Jan 2020 21:13:48 -0500 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CEFE24125; Thu, 23 Jan 2020 02:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579745628; bh=UVtHGuBwD4NKnOj+Kfsya+kpYb2Ei7ghhepkkktbhCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bDZDIFzZTL682ulrwViKOe3ewyQMdqkVmdmvds4xrpPq8JiU9RfR7qcpjFRab+o8R PiUYSZiGGtYjMeFGuBcGEK/Qsg/TCaVD+tNFJWPm5ZNhjNF2928EPwaguDVdEh+cr6 6tmFC6YDE4ITDDWouK47F3UXSqAHzvvr2BLnLGfM= Date: Wed, 22 Jan 2020 18:13:46 -0800 From: Eric Biggers To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Hridya Valsaraju Subject: Re: [PATCH 2/2] f2fs: Add f2fs stats to sysfs Message-ID: <20200123021346.GA862@sol.localdomain> References: <20200123011354.75282-1-jaegeuk@kernel.org> <20200123011354.75282-2-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123011354.75282-2-jaegeuk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 22, 2020 at 05:13:54PM -0800, Jaegeuk Kim wrote: > diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c > index ce2936554ef8..7565ba9967dd 100644 > --- a/fs/f2fs/debug.c > +++ b/fs/f2fs/debug.c > @@ -150,7 +150,7 @@ static void update_general_status(struct f2fs_sb_info *sbi) > /* > * This function calculates BDF of every segments > */ > -static void update_sit_info(struct f2fs_sb_info *sbi) > +void update_sit_info(struct f2fs_sb_info *sbi) > { > struct f2fs_stat_info *si = F2FS_STAT(sbi); > unsigned long long blks_per_sec, hblks_per_sec, total_vblocks; Global functions need a "f2fs_" prefix. - Eric