Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp545462ybl; Thu, 23 Jan 2020 03:35:13 -0800 (PST) X-Google-Smtp-Source: APXvYqwXEd1BaxZdtoEr5ZWrtGOefEsyS6tfv+0Qm4POUqMtsUj2m6TM+mVlb7uxb1e151Mt6au3 X-Received: by 2002:a9d:73d9:: with SMTP id m25mr11173266otk.350.1579779313149; Thu, 23 Jan 2020 03:35:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579779313; cv=none; d=google.com; s=arc-20160816; b=YbvgaQfW6jLfs0PeAEK7wNd3lF5VghCEReU/xjRzDqAwSuEcFjViXYsFm9+yOJj5oE 7J1Z0JaIpvH1qgp0o9n0ZWjQ4EJP2/HeC64g9P7F70I9EfdiiUUs8uuqHlBsW9laBs1i 4gcYoI3pxmLWbYnsguEnY5oAMKO6muKg1pUv4z43tgPEf/717l97zthCWKK8KFsyPPMB Zw4QUi5vgCKbukFABhCiuGB1daRcqrp5NXaCsIHzjAmysEwQDHbYP1BfQxOWZu5InH11 CL7sM6vqFZJYtgj/WFWYXNCusix3gIg2IFrf8Ga1XFqrlQ0wnCtLWAbbiEFp7Na2I4nt 2NEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=an1DXklQ9zVXi3abNn+wBg8BUsesL3+oVHj4EUvRyNE=; b=HIWe3O5tbFvXLF22naxULFm8unSEt9+nJ5tQ3iWlMKAD2LFEv2jqvQ5RPt53nBCcyt ++M1pQsHl8inQRafApR042jSDtzJbTfZfwe0YmkAW4+UjKk8w5NZPZW15udQdHN1UO8p Dx2iJrTmypo8dMH7DBol0F+Vb093ubiVkMdaBjkSp557ICroffPOwLDbwCbkVSS8vDCQ RFj3Wd1Fi4kl/E95y0ylppelESsuHJAxBIKxElpdSKupNEzl/hZQmfjUJmUxgeAQrZbR Yc4Hm199U4zYiaG6AuUk+B+B4UrlIdvJ7mYqq+GH9BqostQ7ZvBseSfFDykSIn9RTzAd 5KCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S9EWzw3a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1si778376oic.234.2020.01.23.03.35.01; Thu, 23 Jan 2020 03:35:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S9EWzw3a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbgAWLdr (ORCPT + 99 others); Thu, 23 Jan 2020 06:33:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:46880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbgAWLdr (ORCPT ); Thu, 23 Jan 2020 06:33:47 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1AC5E24125; Thu, 23 Jan 2020 11:33:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579779226; bh=jsDVEn6ja5NJVeYqNpNLIyqtb6IGfpbR451Zikql3UY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S9EWzw3aXLey1uX5iJEdFJaR2r8QCth1t+AU0vJODB0w8rMtaVdGCpgNeJNfwtt76 tZ6VcDHztBxLjlUCtX2/RNcrAA64Nqu8kRm/xQbIL1Y9eIfnR+Tcz7wdZ4dmdHUUq4 jN1KKXQAkHURxAeK1ba7aqzgAKkGFq1TCmLr4qkA= Date: Thu, 23 Jan 2020 12:33:42 +0100 From: Greg KH To: Manivannan Sadhasivam Cc: arnd@arndb.de, smohanad@codeaurora.org, jhugo@codeaurora.org, kvalo@codeaurora.org, bjorn.andersson@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/16] bus: mhi: core: Add support for registering MHI controllers Message-ID: <20200123113342.GA976687@kroah.com> References: <20200123111836.7414-1-manivannan.sadhasivam@linaro.org> <20200123111836.7414-3-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123111836.7414-3-manivannan.sadhasivam@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2020 at 04:48:22PM +0530, Manivannan Sadhasivam wrote: > +static inline void mhi_dealloc_device(struct mhi_controller *mhi_cntrl, > + struct mhi_device *mhi_dev) > +{ > + kfree(mhi_dev); > +} You just leaked memory, please read the documentation for device_initialize(). :(