Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp779107ybl; Thu, 23 Jan 2020 07:36:04 -0800 (PST) X-Google-Smtp-Source: APXvYqxdIu/P5EFckU/5LApTu0O55lMmdrgiYqBP0VaS+kF1fEparCJlJRu8CphuKcvohv3S8EUv X-Received: by 2002:aca:53c6:: with SMTP id h189mr10954532oib.11.1579793763846; Thu, 23 Jan 2020 07:36:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579793763; cv=none; d=google.com; s=arc-20160816; b=LJ8JkwcBXgkDRbjMQ+xWh0IQFtqu8jtORT66slhUDjFlkWUhAKsjzCOmEtlr+9g3FC RCFsIqZ+h/Au9ANc+UO3S00MP3Zg5tQ+KBIgDxjO9rTOssJ6fLT3yGxIubXCkCJdHPH+ cM61aX47eIYcuq7FDZKqqLKC5AU6mRZQa676fmS+/9uQWJYbYXl3bI7G9k40l0VEeP9B 5UUu+f87eNUlZ9wLZGHenMzyON/Mrzp8agMi12ZUYCe2YTukrLDNf/cfmOrXyvs7Wsgm 3NlMRZa9RIEU+NNIDhKUGgsqvqrZKzZ3119ITpp4TCzvEQa1Gos1L4xbhiZGDMPRy5Xk n+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7E6FEQ/dJXCDv9R+NxzxX+8fQOQYA/lzZPuhC8cr8/g=; b=ho3UrP3fLsjJBnaKY0k8N+oWKovqizZM2q8ksDJ3dXQh4AKzX8yscqaMAToQGG9pZR N3W6pEre0pNoMJpYiwL0PFsGBvwFK8LsfDzENT1Eq4Fm3icFNN++YYYvXbpvZ8/JF1lB oxtGXvHfycbg7GvgxBV7Wgi2eelhVr9qNG4QjgwHs4m63TGQS5AM+lZHrrpnNvwBiCdm 9B/f2h5wp0nf91rWMmUXQyvj9R8wHVn6FKpsJukA+BbZW02dCYbBsMi3aBXp+PzI5sZe 7HGMXBHPR/WsRp1LuCigwaiLaWzmGFdVsk9gJxnXFVZxxrtehCYzxLwko1p9+XGUxIOf ULDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="eVJ0ruE/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si1251908otn.67.2020.01.23.07.35.51; Thu, 23 Jan 2020 07:36:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="eVJ0ruE/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728900AbgAWPdw (ORCPT + 99 others); Thu, 23 Jan 2020 10:33:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:51436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbgAWPdw (ORCPT ); Thu, 23 Jan 2020 10:33:52 -0500 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD09E20684; Thu, 23 Jan 2020 15:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579793631; bh=o6EdoWvDjV0sQGp9eCNVL9r+skCvy+Ya6kW6vxPyTyE=; h=From:To:Cc:Subject:Date:From; b=eVJ0ruE/2Tz0FXXq4dYDrnMPg44Hx3JW5424ZttDI5YrS5iGeA4hZ4cd6LnRSSeFP Yxdq/fqHUA+9YoiUGznrIEuwAAIZBrABumYTxs0BHqHzWsoYY1Re+BraooqllFjP7G RDmgA3eswTIP8bEhFG7WROAQeI4ZpOsq1kbjjkEk= From: Will Deacon To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, kernel-team@android.com, Will Deacon , Michael Ellerman , Peter Zijlstra , Linus Torvalds , Segher Boessenkool , Christian Borntraeger , Luc Van Oostenryck , Arnd Bergmann , Peter Oberparleiter , Masahiro Yamada , Nick Desaulniers Subject: [PATCH v2 00/10] Rework READ_ONCE() to improve codegen Date: Thu, 23 Jan 2020 15:33:31 +0000 Message-Id: <20200123153341.19947-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi folks, This is version two of the patches I previously posted as an RFC here: https://lore.kernel.org/lkml/20200110165636.28035-1-will@kernel.org Changes since then include: * Adopted a less vomit-inducing series of macros for __unqual_scalar_typeof * Cast to 'const' in READ_ONCE() to prevent assignment to the resulting expression * Only warn once at build-time if GCC prior to 4.8 is detected... * ... and then raise the minimum GCC version to 4.8, with an error for older versions of the compiler * Remove some dead gcov code so that the resulting diffstat can distract from those less vomit-inducing macros I mentioned earlier on Failing the build for older compilers is always a contentious topic, so I've done that as a separate couple of patches on the end in case we end up dropping or reverting them. Cheers, Will Cc: Michael Ellerman Cc: Peter Zijlstra Cc: Linus Torvalds Cc: Segher Boessenkool Cc: Christian Borntraeger Cc: Luc Van Oostenryck Cc: Arnd Bergmann Cc: Peter Oberparleiter Cc: Masahiro Yamada Cc: Nick Desaulniers --->8 Will Deacon (10): compiler/gcc: Emit build-time warning for GCC prior to version 4.8 netfilter: Avoid assigning 'const' pointer to non-const pointer fault_inject: Don't rely on "return value" from WRITE_ONCE() READ_ONCE: Simplify implementations of {READ,WRITE}_ONCE() READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() memory accesses READ_ONCE: Drop pointer qualifiers when reading from scalar types locking/barriers: Use '__unqual_scalar_typeof' for load-acquire macros arm64: barrier: Use '__unqual_scalar_typeof' for acquire/release macros compiler/gcc: Raise minimum GCC version for kernel builds to 4.8 gcov: Remove old GCC 3.4 support Documentation/process/changes.rst | 2 +- arch/arm/crypto/Kconfig | 12 +- arch/arm64/include/asm/barrier.h | 16 +- crypto/Kconfig | 1 - drivers/xen/time.c | 2 +- include/asm-generic/barrier.h | 16 +- include/linux/compiler-gcc.h | 5 +- include/linux/compiler.h | 129 +++---- include/linux/compiler_types.h | 21 ++ init/Kconfig | 5 +- kernel/gcov/Kconfig | 24 -- kernel/gcov/Makefile | 3 +- kernel/gcov/gcc_3_4.c | 573 ------------------------------ lib/fault-inject.c | 4 +- net/netfilter/core.c | 2 +- net/xdp/xsk_queue.h | 2 +- scripts/Kconfig.include | 3 + scripts/gcc-plugins/Kconfig | 4 +- 18 files changed, 111 insertions(+), 713 deletions(-) delete mode 100644 kernel/gcov/gcc_3_4.c -- 2.25.0.341.g760bfbb309-goog