Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Helmut Grohne <helmut.grohne@intenta.de>,
        Support Opensource <Support.Opensource@diasemi.com>,
        Lee Jones <lee.jones@linaro.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] mfd: da9062: enable being a system-power-controller
Thread-Topic: [PATCH 1/2] mfd: da9062: enable being a system-power-controller
Thread-Index: AQHVxVLd8ZSwK+YMLk+kKi398FPZzKf4e+UA
Date:   Thu, 23 Jan 2020 15:51:37 +0000
Message-ID: <AM6PR10MB226306BDE8575CED80071148800F0@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM>
References: <20200107120559.GA700@laureti-dev>
In-Reply-To: <20200107120559.GA700@laureti-dev>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.228]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f8d0eda8-b1a9-42ca-faec-08d7a01c216b
x-ms-traffictypediagnostic: AM6PR10MB2614:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM6PR10MB2614FBA31309B76BA4151146A70F0@AM6PR10MB2614.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 029174C036
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(39850400004)(136003)(396003)(346002)(376002)(189003)(199004)(53546011)(6506007)(71200400001)(316002)(110136005)(7696005)(4326008)(55236004)(478600001)(66476007)(66556008)(66446008)(64756008)(76116006)(66946007)(33656002)(2906002)(9686003)(86362001)(55016002)(81156014)(8936002)(8676002)(186003)(5660300002)(26005)(52536014)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR10MB2614;H:AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: diasemi.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HxuwZe4HNfV28RP0v/f2Ox/x0Llp5d2AYsmfEYYZ/OVT3Gt1X9ZS7JMIONnm4DxvV6qE6nXRnJx9Wr26iF1MXZ5sntbWhloOxUzM7ohoY2+zHY4shu5syeiEhVJ9prsQ/rm58V5BgosGf1648UPPsQo7HMvcfhnX2DZw/ho/pOn76A36Cc72U31A/A9QtVOrCOn/Q3qojGfj2zAJOTY2tVJ8IzQFuo/Cj5S9lKmByRiUMXa5fukHG1cCusnmfpE1KC4AL5FzifnNy0nS0ZHsUoKsGxL+TQZ6lnBHhd9Pl7z3HckMjjwqOPCkIztKkzb7gXNhvNv/QxwlIVskm5lHDs2c1O0YYc2bgT05pO3XyrdDpfC8GV1S8hRMS/UPh+weTVdHCrRoyGVnqGDSJMhttXyA848zbSVpcaCTAZiqRYnRyW2QNXwx0xW0Ie9v+Wmc
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8d0eda8-b1a9-42ca-faec-08d7a01c216b
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 15:51:37.5608
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jSsp9VdxQ5W7GalezFwT73MZ1Gx1QFElEzJCz/U76jkex4n8NQZenzx9GRdEEh4eoNwwmQ9rXO7xCSL0nWsVnRD96oWBm07WBlj4EvWddXQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2614
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07 January 2020 12:06, Helmut Grohne wrote:

> The DA9062 can be the device used to power the CPU. In that case, it can
> be used to power off the system. In the CONTROL_A register, the M_*_EN
> bits must be zero for the corresponding *_EN bits to have an effect. We
> zero them all to turn off the system.
>=20
> Signed-off-by: Helmut Grohne <helmut.grohne@intenta.de>
> ---
>  drivers/mfd/da9062-core.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>=20
> This patch includes the functionality into the da9062-core driver. If
> that is not the preferred way to integrate it, it can be added as a
> mfd_cell instead. In that case, I can move the functionality to a new
> drivers/power/reset/da9062-poweroff.c. As far as I can see, doing so
> implies that we can no longer use the standard system-power-controller
> property though and must use a new compatible property
> dlg,da9062-poweroff. Please let me know your preference.

I have concerns about using regmap/I2C within the pm_power_off() callback
function although I am aware there are other examples of this in the kernel=
. At
the point that is called I believe IRQs are disabled so it would require a
platform to have an atomic version of the I2C bus's xfer function. Don't kn=
ow
if there's a check to see if the bus supports this, but if not then maybe i=
t's
something worth adding? That way we can then only support the pm_power_off(=
)
approach on systems which can actually do it.

>=20
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index e69626867c26..a2b5dfee677f 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -572,6 +572,23 @@ static const struct of_device_id da9062_dt_ids[] =3D=
 {
>  };
>  MODULE_DEVICE_TABLE(of, da9062_dt_ids);
>=20
> +/* Hold client since pm_power_off is global. */
> +static struct i2c_client *da9062_i2c_client;
> +
> +static void da9062_power_off(void)
> +{
> +	struct da9062 *chip =3D i2c_get_clientdata(da9062_i2c_client);
> +	const unsigned int mask =3D DA9062AA_SYSTEM_EN_MASK |
> +		DA9062AA_POWER_EN_MASK | DA9062AA_POWER1_EN_MASK
> |
> +		DA9062AA_M_SYSTEM_EN_MASK |
> DA9062AA_M_POWER_EN_MASK |
> +		DA9062AA_M_POWER1_EN_MASK;
> +	int ret =3D regmap_update_bits(chip->regmap, DA9062AA_CONTROL_A,
> mask, 0);
> +
> +	if (ret < 0)
> +		dev_err(&da9062_i2c_client->dev,
> +			"DA9062AA_CONTROL_A update failed, %d\n", ret);
> +}
> +
>  static int da9062_i2c_probe(struct i2c_client *i2c,
>  	const struct i2c_device_id *id)
>  {
> @@ -661,6 +678,15 @@ static int da9062_i2c_probe(struct i2c_client *i2c,
>  		return ret;
>  	}
>=20
> +	if (of_device_is_system_power_controller(i2c->dev.of_node)) {
> +		if (!pm_power_off) {
> +			da9062_i2c_client =3D i2c;
> +			pm_power_off =3D da9062_power_off;
> +		} else {
> +			dev_warn(&i2c->dev, "Poweroff callback already
> assigned\n");
> +		}
> +	}
> +
>  	return ret;
>  }
>=20
> @@ -668,6 +694,11 @@ static int da9062_i2c_remove(struct i2c_client *i2c)
>  {
>  	struct da9062 *chip =3D i2c_get_clientdata(i2c);
>=20
> +	if (pm_power_off =3D=3D da9062_power_off)
> +		pm_power_off =3D NULL;
> +	if (da9062_i2c_client)
> +		da9062_i2c_client =3D NULL;
> +
>  	mfd_remove_devices(chip->dev);
>  	regmap_del_irq_chip(i2c->irq, chip->regmap_irq);
>=20
> --
> 2.20.1